General

Profile

Rishabh Dave's activity

From 05/31/2020 to 06/29/2020

06/29/2020

07:44 AM CephFS Feature #46059 (Fix Under Review): vstart_runner.py: optionally rotate logs between tests
Rishabh Dave

06/22/2020

01:03 PM CephFS Bug #46100 (Fix Under Review): vstart_runner.py: check for Raw instance before treating as iterable
Rishabh Dave
01:03 PM CephFS Bug #46101 (Fix Under Review): qa: set omit_sudo to False for cmds executed with sudo
Rishabh Dave

06/19/2020

08:51 AM Ceph Revision 90727ee4 (ceph): qa: add omit_sudo=False for commands ran with sudo
Commands that cleanup FUSE and kernel mount and that setup and
teardown/cleanup network namespaces are that ones that...
Rishabh Dave
06:49 AM CephFS Bug #46101 (Resolved): qa: set omit_sudo to False for cmds executed with sudo
There are 2 set of distinct commands -- first are commands that setup and teardown network namespaces and second are ... Rishabh Dave
06:43 AM Ceph Revision 1ff990c2 (ceph): vstart_runner.py: improve a conditional in _do_run
Before checking for "/" in args[0], check if it's an instance of Raw.
Since Raw instances aren't iterable, the execut...
Rishabh Dave
06:41 AM CephFS Bug #46100 (Resolved): vstart_runner.py: check for Raw instance before treating as iterable
... Rishabh Dave

06/17/2020

05:43 PM Ceph Revision 23f279d7 (ceph): qa/cephfs: don't pass cmd args from run_as_user as str
Passing command arguments from run_as_user() to run_shell() as string
can be problematic since command argument to be...
Rishabh Dave
05:42 PM Ceph Revision 4c9811aa (ceph): qa/cephfs: refactor run_as_root() to user run_as_user()
Signed-off-by: Rishabh Dave <ridave@redhat.com> Rishabh Dave
05:41 PM CephFS Bug #46057 (Resolved): qa/cephfs: run_as_user must args list instead of str
Running @self.mount_a.run_as_root(args='ls ~')@ leads to following error -... Rishabh Dave
11:51 AM Ceph Revision 58c7c7e8 (ceph): test_cephfs_shell: run cephfs-shell with conf file
And set colors to False and debug to True in this conf file.
stdout captured by Python code in this testsuite can co...
Rishabh Dave
09:12 AM Ceph Revision cc8f1581 (ceph): vstart_runner: set default values of stdout and stderr to None
Not doing so leads to tests run successfully with vstart_runner.py but
crash when triggered with teuthology since the...
Rishabh Dave

06/16/2020

04:51 PM Ceph Revision f0018b9f (ceph): qa/cephfs: add FUSE module before running mount -t fusectl
Also, change timeout from 15 minutes to 30 seconds for the command
"mount -t fusectl xxx xxx" since 15 minutes is too...
Rishabh Dave

06/15/2020

09:43 AM Ceph Revision 2d15a102 (ceph): test_volume_client: simplify test_get_authorized_ids()
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 79d62dd87461c43dd6df3775f21962be9042a7b1)
Rishabh Dave

06/14/2020

08:34 AM Ceph Revision 88e0be4c (ceph): qa/cephfs: use StringIO instead of BytesIO
Fixes: https://tracker.ceph.com/issues/45425
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from comm...
Rishabh Dave
08:34 AM Ceph Revision 778859de (ceph): vstart_runner.py: use tuple instead of set
Using python3 leads to an error that says
"TypeError: unhashable type: 'Raw'".
Fixes: https://tracker.ceph.com/issue...
Rishabh Dave

06/11/2020

01:14 PM CephFS Bug #44415 (Fix Under Review): cephfs.pyx: passing empty string is fine but passing None is not t...
Rishabh Dave
12:58 PM Ceph Revision 8ce1cce9 (ceph): doc/dev: mention -l, -e and -n among useful options
Signed-off-by: Rishabh Dave <ridave@redhat.com> Rishabh Dave
12:57 PM Ceph Revision 322896fe (ceph): doc/dev: add info on how to retest QA changes without rebuilding
Add a section to "Running tests using teuthology" in "Developer's Guide"
that explains how to retest a branch without...
Rishabh Dave
11:35 AM Ceph Revision e6873696 (ceph): vstart_runner: set omit_sudo to True by default
Let's set omit_sudo to True by default since we don't to run
commands with sudo on developer's machine as far as poss...
Rishabh Dave

06/10/2020

12:28 PM CephFS Bug #45815 (Fix Under Review): vstart_runner.py: set stdout and stderr to None by default
Rishabh Dave

06/09/2020

12:44 PM Ceph Revision 4b9ba3d8 (ceph): qa/cephfs: make run_shell() accept args as str too
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit a83ea849d7d2096762a125b8c6dbb8eb9988b2a9)
...
Rishabh Dave

06/06/2020

08:39 AM Ceph Revision b8886c15 (ceph): vstart_runner: set mounted to True at the end of mount()
Not doing so prevents cleanup methods from running.
Fixes: https://tracker.ceph.com/issues/45723
Signed-off-by: Rish...
Rishabh Dave

06/05/2020

04:11 AM Ceph Revision a11b3c01 (ceph): test_cephfs_shell: catch specific exception instead of catching all
Signed-off-by: Rishabh Dave <ridave@redhat.com> Rishabh Dave
04:11 AM Ceph Revision 99d944ce (ceph): test_cephfs_shell: remove test_every_shell_cmd_at_invocation
The reason behind adding and removing this test in different commits of
the same PR is that test_every_shell_cmd_at_i...
Rishabh Dave
04:11 AM Ceph Revision 9b2077ff (ceph): cephfs-shell: set return value before exiting
Code for each command has a return value set yet cephfs-shell itself
doesn't exit with proper return value. This make...
Rishabh Dave
04:01 AM Ceph Revision c4bd10bd (ceph): test_cephfs_shell: re-arrange TestCephFSShell's methods
Re-arrange in the order of their usefulness and use keyword arguments
instead of positional arguments to reduce chanc...
Rishabh Dave
03:58 AM Ceph Revision d0be1f9f (ceph): test_cephfs_shell: add new test for shell cmd at invocation
Test passing each CephFS shell command at invocation of shell. The test
replaces run_cephfs_shell_cmd (and other rela...
Rishabh Dave
03:58 AM Ceph Revision 3d6feb0f (ceph): cephfs-shell: re-arrange code under __main__
Move code from __main__ to different methods to avoid sequence of block
of code that are not strictly related to each...
Rishabh Dave
03:56 AM Ceph Revision 2d5201fd (ceph): cephfs-shell: launch shell only if there are no args following
Commands like "cephfs-shell mkdir a" should just create the directory
and quit immediately with the command's return ...
Rishabh Dave

06/04/2020

06:32 PM Ceph Revision b67ce004 (ceph): test_cephfs_shell: use StringIO instead of BytesIO
Code in qa/ uses both StringIO and BytesIO. Let's use StringIO
exclusively (unless necessary) for uniformity. The rea...
Rishabh Dave
01:56 PM Ceph Revision eb87b54a (ceph): qa/cephfs: add FUSE module before running mount -t fusectl
Also, change timeout from 15 minutes to 30 seconds for the command
"mount -t fusectl xxx xxx" since 15 minutes is too...
Rishabh Dave
01:38 PM Ceph Revision a891fd9f (ceph): vstart_runner: set mounted to True at the end of mount()
Not doing so prevents cleanup methods from running.
Fixes: https://tracker.ceph.com/issues/45723
Signed-off-by: Rish...
Rishabh Dave

06/03/2020

11:57 AM Ceph Revision c04e0be7 (ceph): test_sessionmap: use sudo_write_file() from teuthology.misc
Instead of defining a method to write files within the testsuite, use
sudo_write_file() from teuthology.misc.
Signed...
Rishabh Dave
11:57 AM Ceph Revision d26addf3 (ceph): vstart_runner.py: use tuple instead of set
Using python3 leads to an error that says
"TypeError: unhashable type: 'Raw'".
Fixes: https://tracker.ceph.com/issue...
Rishabh Dave

06/02/2020

01:32 PM CephFS Bug #45813 (Duplicate): qa/cephfs: tests kclient crash with "unexpected keyword" error
Closing in favour of https://tracker.ceph.com/issues/45300 Rishabh Dave
12:10 PM CephFS Bug #45813 (Fix Under Review): qa/cephfs: tests kclient crash with "unexpected keyword" error
Rishabh Dave
10:59 AM CephFS Bug #45813 (Duplicate): qa/cephfs: tests kclient crash with "unexpected keyword" error
@mount_wait()@ was added to mount.py with the assumption that all mount methods accept mountpoint in "this commit":ht... Rishabh Dave
12:36 PM CephFS Bug #45815 (Resolved): vstart_runner.py: set stdout and stderr to None by default
Right now both are set to BytesIO() in LocalRemoteProcess.__init__() when values are not passed. See - https://github... Rishabh Dave
11:59 AM Ceph Revision 49e9faee (ceph): qa/vstart_runner.py: ignores when source and destination are same
put_file() in vstart_runner.py should ignore the error when source and
destination paths supplied are the same. Sourc...
Rishabh Dave
11:40 AM Ceph Revision a4040bf0 (ceph): vstart_runner: don't use namespaces by default
And add option --usens to vstart_runner.py to use namespaces.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave
11:37 AM Ceph Revision 04d501d6 (ceph): qa/cephfs: run nsenter commands with superuser privileges
And add a method that sets self.fuse_daemon.subproc.pid to the PID of
the process that doesn't have sudo in its argum...
Rishabh Dave

06/01/2020

06:23 PM Ceph Revision ea143281 (ceph): qa/cephfs: look for mountpoint in cmdline file
Look for self.mountpoint in the contents of /proc/<pid>/cmdline file
when finding asok file for the client so that vs...
Rishabh Dave
 

Also available in: Atom