General

Profile

Ernesto Puerta's activity

From 07/22/2019 to 08/20/2019

08/20/2019

07:31 PM Dashboard Bug #41358 (Resolved): mgr/dashboard: refactor SSO service
After unit test clean-up (https://github.com/ceph/ceph/pull/28696), it seems that SSO unit test is failing in FreeBSD... Ernesto Puerta

08/16/2019

05:56 PM Dashboard Bug #41320 (Resolved): mgr/dashboard: passwords and other sensitive information is written to logs
Currently dashboard is storing in plain text logs the following sentitive information:
- -Dashboard user names, pa...
Ernesto Puerta
05:17 PM Ceph Revision 1e07237d (ceph): mgr/dashboard: clean-up tox and unit tests
Refactor CMake add_tox_test to automatically add py27 and/or py3 to
provided toxenvs.
Refactor tox.ini:
- Remove req...
Ernesto Puerta
01:24 PM Ceph Revision f4cbe896 (ceph): mgr/dashboard: clean-up python unit tests
Fix pylint issues.
Refactor JwtManager check to avoid code duplication (found by pylint
when --jobs=1).
Fix issue w...
Ernesto Puerta
10:07 AM Dashboard Bug #41244: mgr/dashboard: Confusing naming of buttons in edit dialogs
Patrick, you may find more context on this discussion here: https://tracker.ceph.com/issues/37337#note-9
That said...
Ernesto Puerta
09:57 AM mgr Bug #38614: Disable SSLv3 on ceph-mgr?
Just saw a traceback in python "SSLError: [SSL: SSLV3_ALERT_CERTIFICATE_UNKNOWN] sslv3 alert certificate unknown (_ss... Ernesto Puerta
09:08 AM Dashboard Bug #41309 (Resolved): mgr/dashboard: landing page has layout/formatting issues
2 issues detected in landing page:
* White background stripe in the bottom. It also varies in width when the layou...
Ernesto Puerta

08/13/2019

12:28 PM Dashboard Feature #41152 (In Progress): Check reStructuredText files can be rendered correctly on Github
Used restructured-lint: https://github.com/twolfson/restructuredtext-lint Ernesto Puerta
12:03 PM Dashboard Cleanup #41224 (In Progress): mgr/dashboard: enable flake8-docstrings and fix docstrings
After PR https://github.com/ceph/ceph/pull/28696, flake8 has been enabled in tox, but some tools have been commented ... Ernesto Puerta
08:40 AM Dashboard Cleanup #41221 (Resolved): mgr/dashboard: reduce method (cyclomatic) complexity
PR https://github.com/ceph/ceph/pull/28696 introduces flake8, which allows for extra checkings (naming, etc.). One of... Ernesto Puerta

08/07/2019

04:36 PM Dashboard Cleanup #41155 (Resolved): mgr/dashboard: improve current navigation bar
h3. Current horizontal navbar
!current.png!
h4. Issues
* Requires 2 vertical rows (main menu and helper menu...
Ernesto Puerta
09:18 AM Ceph Feature #41047 (Resolved): github: Add CODEOWNERs file to enforce component/team-based reviews
Ernesto Puerta

08/05/2019

05:45 PM Dashboard Tasks #40748 (Fix Under Review): mgr/dashboard: Automate merging pull requests using Mergify
Ernesto Puerta
12:04 PM Ceph Revision 0d8908a8 (ceph): github: Add CODEOWNERs for component/team reviews
Adds [CODEOWNERS](https://help.github.com/en/articles/about-code-owners)
file and assigns ownership of /src/pybind/mg...
Ernesto Puerta

08/02/2019

07:26 PM Ceph Revision 7f767ab4 (ceph): install-deps.sh: remove failing error catching
Fixes: https://tracker.ceph.com/issues/41013
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Ernesto Puerta
12:08 PM Dashboard Bug #41060 (Resolved): mgr/dashboard: REST API returns 500 when no Content-Type is specified
Right now, a request like this (without @Content-Type: application/json@) results in 500 error + traceback:... Ernesto Puerta

08/01/2019

04:26 PM Ceph Feature #41047 (Fix Under Review): github: Add CODEOWNERs file to enforce component/team-based re...
Ernesto Puerta
02:47 PM Ceph Feature #41047 (Resolved): github: Add CODEOWNERs file to enforce component/team-based reviews
Ernesto Puerta
02:37 PM Ceph Feature #41023 (Resolved): doc: List Jenkins trigger phrases in Pull Request template
Ernesto Puerta

07/31/2019

11:20 AM Ceph Feature #41023 (Fix Under Review): doc: List Jenkins trigger phrases in Pull Request template
Ernesto Puerta
10:56 AM Ceph Feature #41023 (Resolved): doc: List Jenkins trigger phrases in Pull Request template
In order to help remember available PR Jenkins commands, a collapsible list is added. Ernesto Puerta
11:19 AM Ceph Bug #41013 (Fix Under Review): install-deps.sh: fails in CentOS 7.6
Ernesto Puerta
10:58 AM Ceph Revision 4963daf5 (ceph): doc: Show Jenkins commands
Fixes: https://tracker.ceph.com/issues/41023
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Ernesto Puerta

07/30/2019

04:44 PM Ceph Bug #41013 (Resolved): install-deps.sh: fails in CentOS 7.6
After @ensure_decent_gcc_on_rh@, the command "@grep -q -i error: $DIR/yum-builddep.out@" wrongly catches the followin... Ernesto Puerta

07/29/2019

01:11 PM Dashboard Feature #40909: mgr/dashboard: REST API versioning
Sebastian Wagner wrote:
> Ernesto Puerta wrote:
> > * the Rook caching issue was triggered by a change in front-end...
Ernesto Puerta

07/26/2019

04:14 PM Dashboard Feature #40909: mgr/dashboard: REST API versioning
Yes, I'm aware of it. Thanks for the brain food, I really like reading about this stuff.
I think we all agree on t...
Ernesto Puerta
10:37 AM Dashboard Cleanup #40966: mgr/dashboard: simplify Grafana checker ("check_grafana_uids.py")
Thanks for clarifying that Kiefer!
The approach suggested by Kanika is ok too. However, it still requires a mappin...
Ernesto Puerta

07/25/2019

08:08 PM Dashboard Cleanup #40966 (Won't Fix): mgr/dashboard: simplify Grafana checker ("check_grafana_uids.py")
It seems that "check_grafana_uids.py" checks that Grafana front-end UIDs match the UIDs in Grafana dasboard JSON defi... Ernesto Puerta
04:00 PM Dashboard Feature #40296: mgr/dashboard: Maintain and improve code coverage on dashboard PRs
Ooops. My PR on refactoring unit-tests is currently blocked as I'm modifying the behaviour of install-deps.sh script ... Ernesto Puerta
03:46 PM Dashboard Feature #40962 (New): mgr/dashboard: REST API: runtime front-end/back-end (end-to-end) schema val...
While front-end language Typescript provides build-time type-checks, there's no current action taken to ensure run-ti... Ernesto Puerta

07/24/2019

05:38 PM Dashboard Bug #40754: mgr/dashboard: configure HTTP caching for static files (JS/Angular)
On production builds the generate filenames are like (taken from Rook 1.0.3):... Ernesto Puerta

07/23/2019

09:04 PM Dashboard Feature #40914 (Resolved): mgr/dashboard: REST API: security
The following measures should be implemented:
- Failed login limit (after that, the user will be disabled).
- Rate ...
Ernesto Puerta
08:56 PM Dashboard Feature #40913 (New): mgr/dashboard: REST API: HATEOAS support (linking)
"HATEOAS":https://restfulapi.net/hateoas/ or RMM level 3 API describes relationships between resources and links, so ... Ernesto Puerta
08:44 PM Dashboard Feature #40912 (New): mgr/dashboard: REST API: review caching
Back-end server should indicate whether a response can be cached or not according to:
* any sensitive information (u...
Ernesto Puerta
08:41 PM Dashboard Feature #40911 (New): mgr/dashboard: REST API: review endpoints and semantics
Ensure that existing endpoints comply with ("reference":https://github.com/Microsoft/api-guidelines/blob/master/Guide... Ernesto Puerta
07:27 PM Dashboard Backport #40768 (Resolved): nautilus: mgr/dashboard: change Github dep ng2-toastr to NPMJS
Ernesto Puerta
07:21 PM Dashboard Feature #40909 (Resolved): mgr/dashboard: REST API versioning
In order to get an stable API we can either:
- Freeze existing API and allow only additive modifications (i.e.: new ...
Ernesto Puerta
07:00 PM Dashboard Feature #40907 (New): mgr/dashboard: REST API improvements
Epic tracker issue to collect all features/fixes to improve status of REST API.
"REST Standards":https://standards...
Ernesto Puerta
 

Also available in: Atom