Project

General

Profile

Bug #9904

Don't crash MDS on clients sending messages with bad seq

Added by John Spray over 9 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently in Server::handle_client_session, we do this:

      if (m->get_seq() != session->get_push_seq()) {
    dout(0) << "old push seq " << m->get_seq() << " != " << session->get_push_seq() 
        << ", BUGGY!" << dendl;
    assert(0);
      }

This probably isn't the only case where we crash on malformed client messages, but it's readily identifiable as one that we could handle better.

History

#1 Updated by Brett Niver almost 8 years ago

  • Assignee set to Brett Niver

#2 Updated by Brett Niver almost 8 years ago

  • Status changed from New to In Progress

#3 Updated by John Spray almost 8 years ago

  • Status changed from In Progress to Fix Under Review

#4 Updated by John Spray almost 8 years ago

  • Status changed from Fix Under Review to Resolved

#5 Updated by Greg Farnum over 7 years ago

  • Component(FS) MDS added

Also available in: Atom PDF