Project

General

Profile

Actions

Bug #9536

closed

erasure-code: ISA plugin alignment must be constant

Added by Loïc Dachary over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
OSD
Target version:
% Done:

80%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

28c2b6e4f2bc6d77b9150fcf9a917d85c69c9ed1

EC_ISA_VECTOR_OP_WORDSIZE depends on the compiler version and other compile time facts. It is used to compute the chunck size via the get_alignment() function. It is therefore possible that two isa binaries will come up with different chunk sizes because they were compiled in different environment. This in turn will lead to OSDs disagreeing on the chunk size.

The simpler fix is to use a constant, unless this is problematic for some reason.

Actions #1

Updated by Loïc Dachary over 9 years ago

  • Status changed from 12 to In Progress
Actions #2

Updated by Loïc Dachary over 9 years ago

  • Category set to OSD
  • Status changed from In Progress to Fix Under Review
  • Target version set to 0.88
Actions #3

Updated by Loïc Dachary over 9 years ago

  • % Done changed from 0 to 80
Actions #4

Updated by Sage Weil over 9 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Sage Weil over 9 years ago

  • Priority changed from Urgent to High
  • Source changed from other to Development
  • Backport set to firefly

(parts of) this will need to be backported with the rest of the ISA plugin stuff

Actions #6

Updated by Loïc Dachary over 9 years ago

  • Description updated (diff)
Actions #7

Updated by Loïc Dachary about 9 years ago

  • Description updated (diff)
  • Backport changed from firefly to firefly,giant
Actions #8

Updated by Loïc Dachary about 9 years ago

  • Description updated (diff)
Actions #9

Updated by Loïc Dachary about 9 years ago

  • Status changed from Pending Backport to Resolved
  • Backport deleted (firefly,giant)

it already is in giant and the isa plugin does not exist in firefly

Actions

Also available in: Atom PDF