Project

General

Profile

Actions
Copy link

Bug #7751

closed

os: LevelDBStore: needs to check iter->status() during get()

Added by Joao Eduardo Luis about 10 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Joao Eduardo Luis
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We are ignoring the status of the iterator during 'LevelDBStore::get()' -- we're also ignoring the state of the iterator on our iterator class itself.

This opens us to assuming everything is right when the underlying db may actually be in bad shape.

Actions
Copy link
 #1

Updated by Loïc Dachary almost 9 years ago

  • Regression set to No

A link to the relevant part of the code would be useful

Actions
Copy link
 #2

Updated by Sage Weil almost 9 years ago

  • Assignee set to Joao Eduardo Luis
Actions
Copy link
 #3

Updated by Sage Weil about 7 years ago

  • Status changed from New to Closed
Actions
Copy link
 #4

Updated by Greg Farnum about 7 years ago

  • Status changed from Closed to Need More Info
Actions
Copy link
 #5

Updated by Joao Eduardo Luis about 7 years ago

  • Status changed from Need More Info to Closed

If this was an issue, it shouldn't be anymore.

LevelDBStore::get() handles the case where its status is not 'okay'. It should then be the caller's responsibility to act accordingly - for the monitor, I opened http://tracker.ceph.com/issues/19601 for those cases that do not.

Actions
Copy link

Also available in: Atom PDF