Bug #678: What if period == 0 in MDCache...purge_stray? - CephFS - Ceph

Actions

Copy link

Bug #678

closed

What if period == 0 in MDCache...purge_stray?

Added by Paul Komkoff over 13 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Sage Weil

Category:

Target version:

% Done:

100%

Source:

Tags:

Backport:

Regression:

Severity:

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Program terminated with signal 8, Arithmetic exception.
#0 0x000000000052f8c2 in MDCache::purge_stray (this=0x240c9b0, dn=0x7f49e86c05a8) at mds/MDCache.cc:7413
7413 uint64_t num = (to + period - 1) / period;

Workaround attached.

Files

ceph-period.patch (1.34 KB) ceph-period.patch

Paul Komkoff, 01/01/2011 05:04 AM

Actions

Copy link

Updated by Sage Weil over 13 years ago

The question is whether this was a regular file (shouldn't have a 0 period!) or a directory (we need to delete the metadata objects, and the old purge logic is useless anyway). Either way a fix is in order, with the above 0 check for sanity.

Actions

Copy link

Updated by Sage Weil over 13 years ago

Target version set to v0.24.1

Actions

Copy link

Updated by Paul Komkoff over 13 years ago

Based on what I was doing when this asplode I'd say it's either a directory or a file created but not yet written to and client then crashed. But it's a speculation as I nuked the coredump away already.

Actions

Copy link