Project

General

Profile

Actions

Bug #6672

closed

normal PUT object requests got 405 sometimes

Added by Xiangyu Lv over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
dumpling
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Under load testing, normal PUT object requests got 405 sometimes. The root cause is that there is a defect in hex_to_num() to decode url in multi-threading context.

Actions #1

Updated by Xiangyu Lv over 10 years ago

A quick fix is to set initialized to true after populating table in hex_to_num().

Please help review the fix at: https://github.com/ceph/ceph/pull/783

Actions #2

Updated by Yehuda Sadeh over 10 years ago

  • Tracker changed from Fix to Bug

Thanks, the initialization code is indeed not safe. See my comment in the pull request.

Actions #3

Updated by Yehuda Sadeh over 10 years ago

  • Backport set to dumpling
Actions #4

Updated by Ian Colle over 10 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Yehuda Sadeh
Actions #5

Updated by Xiangyu Lv over 10 years ago

Updated with a new commit. Please help review it at https://github.com/ceph/ceph/pull/783

Actions #6

Updated by Xiangyu Lv over 10 years ago

Send the pull request against the 'next' branch at https://github.com/ceph/ceph/pull/795

Actions #7

Updated by Yehuda Sadeh over 10 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #8

Updated by Yehuda Sadeh over 10 years ago

  • Status changed from Pending Backport to Resolved

Added signed-off by (with approval of author) and merged into dumpling at commit:372f62717c56d9ab883ae2942e13d6d8d37c2925. Original non-dumpling commit still missing signed-off-by line (not much we can do about it without rebasing everything).

Actions

Also available in: Atom PDF