Project

General

Profile

Actions

Bug #65511

open

cephadm: anonymous_access: false is dropped from grafana spec after apply

Added by Adam King 17 days ago. Updated 3 days ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
squid, reef, quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

[ceph: root@vm-00 /]# cat grafana.yaml 
service_type: grafana
service_name: grafana
placement:
  count: 1
spec:
  anonymous_access: False
  initial_admin_password: password
  protocol: https
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# ceph orch apply -i grafana.yaml 
Scheduled grafana update...
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# ceph orch ls grafana --export               
service_type: grafana
service_name: grafana
placement:
  count: 1
spec:
  anonymous_access: true
  initial_admin_password: password
  protocol: https

This seems to be because it is a bool that defaults to true, which in hindsight was a bad idea. However, it has been merged and backported to the reef and quincy branches for over a year now, so it's hard to change the attribute. I think for this case we may need special handling when converting grafana specs from python objects to JSON serializable dicts.


Related issues 3 (3 open0 closed)

Copied to Orchestrator - Backport #65724: squid: cephadm: anonymous_access: false is dropped from grafana spec after applyNewAdam KingActions
Copied to Orchestrator - Backport #65725: reef: cephadm: anonymous_access: false is dropped from grafana spec after applyNewAdam KingActions
Copied to Orchestrator - Backport #65726: quincy: cephadm: anonymous_access: false is dropped from grafana spec after applyNewAdam KingActions
Actions #1

Updated by Adam King 17 days ago

  • Subject changed from cephadm: anonymous_access: true is dropped from grafana spec after apply to cephadm: anonymous_access: false is dropped from grafana spec after apply
  • Description updated (diff)
Actions #2

Updated by Adam King 17 days ago

  • Description updated (diff)
Actions #3

Updated by Adam King 17 days ago

  • Pull request ID set to 56928
Actions #4

Updated by Adam King 3 days ago

  • Project changed from Ceph to Orchestrator
  • Status changed from In Progress to Pending Backport
Actions #5

Updated by Backport Bot 3 days ago

  • Copied to Backport #65724: squid: cephadm: anonymous_access: false is dropped from grafana spec after apply added
Actions #6

Updated by Backport Bot 3 days ago

  • Copied to Backport #65725: reef: cephadm: anonymous_access: false is dropped from grafana spec after apply added
Actions #7

Updated by Backport Bot 3 days ago

  • Copied to Backport #65726: quincy: cephadm: anonymous_access: false is dropped from grafana spec after apply added
Actions #8

Updated by Backport Bot 3 days ago

  • Tags set to backport_processed
Actions

Also available in: Atom PDF