Project

General

Profile

Actions

Bug #64267

open

cephadm: host maintenance force flag warning misleading

Added by Eugen Block 3 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
orchestrator
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Ceph version 18.2.1

When trying to set a host into maintenance mode you're asked for the --force flag in case ok-to-stop would not allow it. But the error message remains even when --force is passed to the command:


host1:~ # ceph orch host maintenance enter host3
unsafe to stop osd(s) at this time (10 PGs are or would become offline) 
Note: Warnings can be bypassed with the --force flag 

host1:~ # ceph orch host maintenance enter host3 --force 
unsafe to stop osd(s) at this time (10 PGs are or would become offline) 
Note: Warnings can be bypassed with the --force flag

Reading the code [1] I believe this msg

                    msg + '\nNote: Warnings can be bypassed with the --force flag', errno=rc)

should reference the --yes-i-really-mean-it flag instead.
Reading the help output you're pointed towards the --yes-i-really-mean-it flag:

orch host maintenance enter <hostname> [--force] [--yes-i-really-mean-it]

Providing only the --yes-i-really-mean-it flag correctly shows how to do it correctly:

host1:~ # ceph orch host maintenance enter host3 --yes-i-really-mean-it 
Error EINVAL: --force must be passed with --yes-i-really-mean-it

[1] https://github.com/ceph/ceph/blob/v19.0.0/src/pybind/mgr/cephadm/module.py#L1897

No data to display

Actions

Also available in: Atom PDF