Project

General

Profile

Actions

Tasks #64252

open

Feature #63663: mds,client: add crash-consistent snapshot support

Update the --reset semantics to support the CSI plugin workflow

Added by Leonid Usov 3 months ago. Updated 3 months ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

100%

Tags:
Reviewed:
Affected Versions:
Component(FS):
Labels (FS):
Pull request ID:

Description

After talking to Madhu from the CSI team it became clear that we should allow the --reset to force a set with the given id to be moved to QUIESCING state even if it's already in some terminal state.

Since the --reset hasn't been particularly useful until now, mainly combining the effects of --exclude and --include, it does seem reasonable to rethink this command as a special case to reclaim a set by external id.

The requirement is then as follows:

  • for a new set, `--reset sub1 sub2 sub3` should be equivalent to `--include sub1 sub2 sub3`
  • for a set that's QUIESCING or QUIESCED, given that the list of roots matches the current list of members, the command should not affect the current state
    • This is similar to how `--include` would work in case it lists roots that are already part of the set
    • If `--await` or `--await-for` is specified, it affects the command behavior and the return code as it would for a corresponding --include command
  • A set in any other state will be forced back to QUIESCING and all relevant roots will be forced into QUIESCING. Roots that arent listed in the reset command will be excluded.
Actions #1

Updated by Leonid Usov 3 months ago

  • Status changed from In Progress to Fix Under Review
  • % Done changed from 0 to 90
Actions #2

Updated by Leonid Usov 3 months ago

  • Assignee set to Leonid Usov
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF