Project

General

Profile

Actions

Bug #64089

open

mgr/dashboard: allow sending back error status code in case cmd to fetch clients fails

Added by Dhairya Parmar 4 months ago. Updated 3 months ago.

Status:
Fix Under Review
Priority:
Normal
Category:
Component - CephFS
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
fs
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Description of problem

If there is no MDS to serve when a ceph tell cmd is executed, it is but obviously going to return an errno to the CLI and the API (like clients to fetch client sessions) used to return back error status code but with the changes in https://github.com/ceph/ceph/pull/52076, APIs (like `/api/cephfs/<fs_id>/clients`) would return 200 instead of a err status code (like 500) because the function get() in class CephFSClients would return an empty list i.e. it suppress the err. This might be helpful in cases where there is no MDS but it blocks to run negative tests where we expect to get the error status codes. Therefore it is needed to introduce a flag like `suppress_client_ls_errors` to facilitate sending back errors.

Environment

  • ceph version string:
  • Platform (OS/distro/release):
  • Cluster details (nodes, monitors, OSDs):
  • Did it happen on a stable environment or after a migration/upgrade?:
  • Browser used (e.g.: Version 86.0.4240.198 (Official Build) (64-bit)):

How reproducible

Steps:

  1. ...

Actual results

Please add logs and/or screenshots

Expected results

here

Additional info

here

Actions #1

Updated by Dhairya Parmar 4 months ago

  • Pull request ID set to 55215
Actions #2

Updated by Dhairya Parmar 3 months ago

  • Pull request ID changed from 55215 to 52258

52258 depends on 55215, therefore the commit has been cherry-picked into 52258

Actions

Also available in: Atom PDF