Project

General

Profile

Actions

Bug #6361

closed

mon: 'heap' commands not working

Added by Joao Eduardo Luis over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Category:
Monitor
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
dumpling
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

reason is simple: ceph_heap_profiler_handle_command() in perfglue/heap_profiler.cc expects two args in the vector, the second being the command (the first, I'm assuming, would have been 'heap' in previous versions).

solution: check whether we're using this in other places besides the monitor in the same fashion as it was before, and if so we should either change them to pass only the arguments to the profiler (without the 'heap' as first argument) as the monitor does, and adjust the handler function to not assume 2 arguments; or add 'heap' as the first argument in the vector on the monitor.

Not having this working properly makes the whole profiler unusable. And that's not great.

Actions #1

Updated by Joao Eduardo Luis over 10 years ago

  • Status changed from New to Fix Under Review

wip-6361, pull request 612

Actions #2

Updated by Joao Eduardo Luis over 10 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #3

Updated by Sage Weil over 10 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF