Project

General

Profile

Actions
Copy link

Cleanup #62080

open

check if a piece of code in get_devices() in util/disk.py is well needed

Added by Guillaume Abrioux 10 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

the following code from get_devices() in util/disk.py seems meaningless:

        # If the mapper device is a logical volume it gets excluded
        if is_mapper_device(diskname):
            if lvm.get_device_lvs(diskname):
                continue

my understanding (need to be double-checked):

is_mapper_device(diskname) will check if the path starts with either '/dev/mapper' or '/dev/dm-'
lvm.get_device_lvs(diskname) will check if the device itself has LV on it (lvm on lvm?)

No data to display

Actions
Copy link

Also available in: Atom PDF