Project

General

Profile

Feature #6154

ceph-deploy should be able to use an argument "fs-type" to specify the filesystem type on an OSD.

Added by David Moreau Simard over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ceph-deploy
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

According to the documentation, it seems intended and expected that ceph-deploy should be able to define which filesystem type to be used using "--fs-type"
http://ceph.com/docs/master/rados/deployment/ceph-deploy-osd/

However, ceph-deploy does not accept and use this flag anywhere.
The argument --fs-type can however be passed to "ceph-disk prepare" on an OSD.

It would probably make sense for --fs-type to be usable like so:
ceph-deploy osd prepare {node-name}:{disk}[:{path/to/journal}] --fs-type {fs-type}

0001-Add-fs-type-option-to-the-disk-and-osd-commands.patch View - Add --fs-type option (2.23 KB) Benoît Knecht, 09/17/2013 02:08 AM

History

#1 Updated by Greg Farnum over 10 years ago

As a workaround until this gets implemented, you can specify "fs type = foo" in the ceph.conf (at whatever granularity is appropriate).

#2 Updated by Benoît Knecht over 10 years ago

Here's a patch to add the proposed option. Let me know if it needs adjustments.

#3 Updated by Alfredo Deza over 10 years ago

  • Assignee set to Alfredo Deza

#4 Updated by Alfredo Deza over 10 years ago

Benoit, the patch looks good. Could you ammend the commit to have a `signed-by` signature? This is done with the `-s` flag at commit time.

Also, it would be great if you could send this as a pull request to github.com/ceph/ceph-deploy as it is easier to test (we have a Jenkins bot that does this) and merge.

#6 Updated by Alfredo Deza over 10 years ago

  • Status changed from New to Resolved

Merged into ceph-deploy master branch with hash: 6fb89a6

Also available in: Atom PDF