Project

General

Profile

Bug #6130

SharedPtrRegistry_all.wait_lookup_or_create fails inconsistently

Added by Greg Farnum almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/26/2013
Due date:
% Done:

100%

Spent time:
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

pull request

I noticed via the gitbuilders that this unit test is inconsistently failing. I can run it repeatedly on my dev box and get intermittent failures with the same binary. I assume there's a race in the test code of some kind rather than the SharedPtrRegistry actually being broken.


Related issues

Related to Ceph - Bug #6679: throttle: transient unit test failure Resolved 10/29/2013

Associated revisions

Revision af5281e0 (diff)
Added by Loic Dachary almost 6 years ago

common: move SharedPtrRegistry test after t.join

The thread created to test SharedPtrRegistry race conditions updates a
value ( ptr ) that is tested by the main gtest thread but is not
protected by a lock. Instead of adding a lock, the main thread tests
the value after pthread_join() on the child thread.

http://tracker.ceph.com/issues/6130 fixes #6130

Signed-off-by: Loic Dachary <>

History

#1 Updated by Loic Dachary almost 6 years ago

  • Status changed from New to Verified

while : ; do ./unittest_sharedptr_registry --gtest_filter=SharedPtrRegistry_all.wait_lookup_or_create || break ; done

Note: Google Test filter = SharedPtrRegistry_all.wait_lookup_or_create
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SharedPtrRegistry_all
[ RUN      ] SharedPtrRegistry_all.wait_lookup_or_create
test/common/test_sharedptr_registry.cc:140: Failure
Value of: t.ptr
  Actual: false
Expected: true
[  FAILED  ] SharedPtrRegistry_all.wait_lookup_or_create (1 ms)
[----------] 1 test from SharedPtrRegistry_all (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SharedPtrRegistry_all.wait_lookup_or_create

 1 FAILED TEST

#2 Updated by Loic Dachary almost 6 years ago

  • Status changed from Verified to In Progress

#3 Updated by Loic Dachary almost 6 years ago

  • Status changed from In Progress to Need Review
  • % Done changed from 0 to 90

#4 Updated by Loic Dachary almost 6 years ago

  • Description updated (diff)

#5 Updated by Greg Farnum almost 6 years ago

Sam reviewed and merged into master, commit: 7cc2eb246df14925ca27b8dee19b32e0bdb505a8

#6 Updated by Loic Dachary almost 6 years ago

  • Status changed from Need Review to Resolved
  • % Done changed from 90 to 100

cool :-)

Also available in: Atom PDF