Project

General

Profile

Actions
Copy link

Feature #6024

closed

teuthology: kernel: install distro kernel(s)

Added by Sage Weil over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Sandon Van Ness
Category:
-
Target version:
v0.74
% Done:

100%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:

Related issues 1 (0 open — 1 closed)

Blocks teuthology - Feature #3880: suite: the stable release suites are not currently run against upstream stable kernelsResolvedSandon Van Ness01/19/2013

Actions
Actions
Copy link
 #1

Updated by Ian Colle over 10 years ago

  • Translation missing: en.field_story_points set to 5.00
Actions
Copy link
 #2

Updated by Sage Weil over 10 years ago

  • Status changed from New to 12
Actions
Copy link
 #3

Updated by Ian Colle over 10 years ago

  • Assignee set to Sandon Van Ness
  • Translation missing: en.field_story_points changed from 5.00 to 8.00
Actions
Copy link
 #4

Updated by Ian Colle over 10 years ago

  • Target version changed from v0.68 - continued to v0.69
Actions
Copy link
 #5

Updated by Ian Colle over 10 years ago

  • Status changed from 12 to In Progress
Actions
Copy link
 #6

Updated by Ian Colle over 10 years ago

  • Target version changed from v0.69 to v0.71
Actions
Copy link
 #7

Updated by Ian Colle over 10 years ago

  • Target version changed from v0.71 to v0.73
Actions
Copy link
 #8

Updated by Sage Weil over 10 years ago

  • Target version changed from v0.73 to v0.72 Emperor
Actions
Copy link
 #9

Updated by Ian Colle over 10 years ago

  • Target version changed from v0.72 Emperor to v0.73
Actions
Copy link
 #10

Updated by Sandon Van Ness over 10 years ago

  • Status changed from In Progress to Fix Under Review

The pull request has just been waiting for a review for a while now.

Actions
Copy link
 #11

Updated by Ian Colle over 10 years ago

  • Assignee changed from Sandon Van Ness to Zack Cerza

Zack - please review

Actions
Copy link
 #12

Updated by Sandon Van Ness over 10 years ago

pull request #151.

Actions
Copy link
 #13

Updated by Ian Colle over 10 years ago

  • Target version changed from v0.73 to v0.74
Actions
Copy link
 #14

Updated by Zack Cerza over 10 years ago

  • Assignee changed from Zack Cerza to Sandon Van Ness

I began review on this but changes haven't been made.

Actions
Copy link
 #15

Updated by Sandon Van Ness over 10 years ago

I am confused. There was only one really small basic change suggestion and I am not sure how the rest of the review is at all dependent on making that one change? Are we confusing branches? I was waiting on the rest of the review as I thought the rest of the review was going to happen later?

Actions
Copy link
 #16

Updated by Zack Cerza over 10 years ago

Let's get in the habit of linking PRs so people don't have to go find them.
https://github.com/ceph/teuthology/pull/151/

Actions
Copy link
 #17

Updated by Zack Cerza over 10 years ago

Apologies, I should have kept going with review starting that next Monday while you were on vacation.

One thing that we need with changes like this is documentation - I don't know what all these new functions intend to do and comments would go a long way. For example, a function called 'need_to_install_distro' is calling 'sudo yum install' on a remote system. Why?

Actions
Copy link
 #18

Updated by Sandon Van Ness over 10 years ago

  • Status changed from Fix Under Review to Resolved
  • % Done changed from 0 to 100

This has been merged.

Actions
Copy link

Also available in: Atom PDF