Project

General

Profile

Actions

Cleanup #59581

open

rbd: Remove redundant "last_seen" property from rbd_mirror_peer_site_t struct

Added by Nikhil Ladha about 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
librbd
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

The rbd_mirror_peer_site_t [1] struct is used by rbd_mirror_peer_site_list [2] function to store the information of a peer site. But, in the function we are nowhere setting the value of last_seen property.

Considering that no other function is using the struct to store peer site info, and the last_seen property is redundant, I believe that we could safely remove the property from the structure and save some memory here.

[1] https://github.com/ceph/ceph/blob/main/src/include/rbd/librbd.h#L168
[2] https://github.com/ceph/ceph/blob/main/src/librbd/librbd.cc#L3382

No data to display

Actions

Also available in: Atom PDF