Project

General

Profile

Actions

Bug #5599

closed

ceph-disk: prepare should issue a partprobe on the journal device too

Added by Alexandre Marangone almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Support
Tags:
Backport:
dumpling, cuttlefish
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently, after preparing a disk, we issue a partprobe on the prepared device (ceph data).
When using a separate journal, we should also issue a partprobe on the journal device.

Running:
  1. ceph-disk-prepare /dev/sdc /dev/sdb
  2. ceph-disk-prepare /dev/sdd /dev/sdb

Will result in:
/dev/sdb :
/dev/sdb1 ceph journal, for /dev/sdc1
/dev/sdc :
/dev/sdc1 ceph data, active, cluster ceph, osd.0, journal /dev/sdb1
/dev/sdd :
/dev/sdd1 ceph data, prepared, cluster ceph, osd.1

After running partprobe /dev/sdb:
/dev/sdb :
/dev/sdb1 ceph journal, for /dev/sdc1
/dev/sdb2 ceph journal, for /dev/sdd1
/dev/sdc :
/dev/sdc1 ceph data, active, cluster ceph, osd.0, journal /dev/sdb1
/dev/sdd :
/dev/sdd1 ceph data, prepared, cluster ceph, osd.1, journal /dev/sdb2

The partprobe on the journal device should be called before the partprobe on the osd device.


Files

ceph-disk-journal-probe.patch (809 Bytes) ceph-disk-journal-probe.patch Mark Kirkwood, 08/19/2013 06:09 PM
Actions #1

Updated by Sage Weil almost 11 years ago

  • Priority changed from Normal to High
Actions #2

Updated by Mark Kirkwood over 10 years ago

Fyi a tentative patch has been suggested, using partx rather than partprobe (no idea which might be best mind you):

http://www.spinics.net/lists/ceph-users/msg03258.html

Myself and a colleague have tested the above patch, seems to fix the issue (Cuttlefish on Ubuntu 12.04 and 13.04).

Actions #3

Updated by Mark Kirkwood over 10 years ago

Actually this patch (attached) is probably more in keeping with the code style already used in ceph-disk, uses partprobe on the journal before the data device as suggested above.

Actions #4

Updated by Sage Weil over 10 years ago

  • Status changed from New to Pending Backport
Actions #5

Updated by Sage Weil over 10 years ago

  • Status changed from Pending Backport to Resolved
  • Backport set to dumpling, cuttlefish
Actions

Also available in: Atom PDF