Bug #55: osd: fix transition from snaps -> no snaps -> snaps - Ceph - Ceph

Actions

Copy link

Bug #55

closed

osd: fix transition from snaps -> no snaps -> snaps

Added by Sage Weil almost 14 years ago. Updated over 13 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Yehuda Sadeh

Category:

OSD

Target version:

v0.23

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

After filestore btrfs snaps = 1 -> 0, we may have leftover snap dirs. Later, if we turn them back on again, we'll roll back to a horribly ancient state.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Sage Weil almost 14 years ago

Target version changed from v0.21 to v0.22

Actions

Copy link

Updated by Sage Weil over 13 years ago

Target version changed from v0.22 to v0.23

Actions

Copy link

Updated by Sage Weil over 13 years ago

I think all we need to do is look at current/commit_op_seq. If it is greater than the newest snap, than that snap is stale, because someone went and committed to current/.

An optional arg --osd-use-stale-snap bool would override that. That way you could still manually roll back to an older snap (by, say, deleting/renaming the newest) if you needed to for some reason.

Actions

Copy link