Project

General

Profile

Actions
Copy link

Bug #5182

closed

ceph-disk looks like it tries to mark preexisting OSD partitions with the wrong test

Added by Dan Mick almost 11 years ago. Updated almost 11 years ago.

Status:
Won't Fix
Priority:
High
Assignee:
Sage Weil
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph-disk prepare_dev says, near the end: if not is_partition(data), mark the partition as an OSD
type, udevadm settle, and partprobe. It seems to me that test should be "if is_partition(data)".

Actions
Copy link
 #1

Updated by Anonymous almost 11 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #2

Updated by Sage Weil almost 11 years ago

  • Project changed from Ceph to devops
Actions
Copy link
 #3

Updated by Sage Weil almost 11 years ago

  • Assignee set to Sage Weil
Actions
Copy link
 #4

Updated by Sage Weil almost 11 years ago

  • Status changed from New to Won't Fix

this is correct.. if you do ceph-disk prepare /dev/sdb1 (a partition) we don't touch the partition type. if you do /dev/sdb and we create a partition, then is_partiion(/dev/sdb) == False and we can tag our created partition (path, not data)

Actions
Copy link

Also available in: Atom PDF