Project

General

Profile

Actions
Copy link

Bug #51318

closed

cephfs-mirror: do not terminate on SIGHUP

Added by Venky Shankar almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Venky Shankar
Category:
-
Target version:
Ceph - v17.0.0
% Done:

0%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
41988
Crash signature (v1):
Crash signature (v2):

Description

So, utilities such as logrotate would send SIGHUP to the daemon which would terminate it. This is being seen in some of the testing that being done.

But, the logrotate.conf that ceph uses looks like::

/var/log/ceph/*.log {
    rotate 7
    daily
    compress
    sharedscripts
    postrotate
        killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw rbd-mirror || pkill -1 -x "ceph-mon|ceph-mgr|ceph-mds|ceph-osd|ceph-fuse|radosgw|rbd-mirror" || true
    endscript
    missingok
    notifempty
    su root ceph
}

... which does not have an entry for cephfs-mirror. So, not sure why the mirror daemon would get terminated each day. But the daemon should handle SIGHUP anyway.

Related issues 1 (0 open — 1 closed)

Copied to CephFS - Backport #51413: pacific: cephfs-mirror: do not terminate on SIGHUPResolvedVenky ShankarActions
Actions
Copy link
 #1

Updated by Venky Shankar almost 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 41988
Actions
Copy link
 #2

Updated by Patrick Donnelly almost 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #3

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #51413: pacific: cephfs-mirror: do not terminate on SIGHUP added
Actions
Copy link
 #4

Updated by Loïc Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF