Project

General

Profile

Actions

Bug #50442

closed

cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots

Added by Venky Shankar about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.


Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #50629: pacific: cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshotsResolvedVenky ShankarActions
Actions #1

Updated by Patrick Donnelly about 3 years ago

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

Actions #2

Updated by Venky Shankar about 3 years ago

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

# ls /mnt/syncvol1/volumes/_nogroup/subvol1/.snap
snap1

# ls /mnt/syncvol1/volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb/.snap
_snap1_1099511627779

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

Actions #3

Updated by Patrick Donnelly about 3 years ago

Venky Shankar wrote:

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

[...]

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

Right but I'd rephrase the description: ignore snapshots on parent directories when considering snapshots to synchronize. Better or not?

Actions #4

Updated by Venky Shankar about 3 years ago

  • Subject changed from cephfs-mirror: ignore internal snapshots during synchronization to cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots

Patrick Donnelly wrote:

Venky Shankar wrote:

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

[...]

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

Right but I'd rephrase the description: ignore snapshots on parent directories when considering snapshots to synchronize. Better or not?

spot on.

Actions #5

Updated by Venky Shankar about 3 years ago

  • Status changed from New to In Progress
Actions #6

Updated by Venky Shankar about 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 40962
Actions #7

Updated by Patrick Donnelly almost 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #8

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #50629: pacific: cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots added
Actions #9

Updated by Loïc Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF