Bug #50035
closedcephfs-mirror: use sensible mount/shutdown timeouts
0%
Description
The mirror daemon just relies on the defaults which are pretty high:
Option("client_mount_timeout", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED)
.set_default(300.0)
.set_description("timeout for mounting CephFS (seconds)"),
Option("client_shutdown_timeout", Option::TYPE_SECS, Option::LEVEL_ADVANCED)
.set_flag(Option::FLAG_RUNTIME)
.set_default(30)
.set_min(0)
.set_description("timeout for shutting down CephFS")
.set_long_description("Timeout for shutting down CephFS via unmount or shutdown.")
.add_tag("client")
Especially `client_mount_timeout`. When a (remote) filesystem is not reachable (for various reason), this can stall the updater timer thread for 300 seconds! `cephfs-mirror` should define (in its config) and use sensible defaults. It's ok to fail mounting a remote file system since the mirror daemon will retry connecting periodically.
Updated by Patrick Donnelly about 3 years ago
- Status changed from New to Triaged
- Assignee set to Venky Shankar
Updated by Venky Shankar about 3 years ago
Mostly setting this as a config option (in ceph.conf) would suffice. However, cephfs-mirror can connect to the remote cluster with monitor addresss and does not require remote cluster ceph config file on the primary cluster. How would we want the apply remote cluster config in this case?
Updated by Patrick Donnelly about 3 years ago
Venky Shankar wrote:
Mostly setting this as a config option (in ceph.conf) would suffice. However, cephfs-mirror can connect to the remote cluster with monitor addresss and does not require remote cluster ceph config file on the primary cluster. How would we want the apply remote cluster config in this case?
cephfs-mirror can update the defaults in its cct->_conf. It woudl do this for both CephContexts it holds for each cluster, right?
Updated by Venky Shankar about 3 years ago
Patrick Donnelly wrote:
Venky Shankar wrote:
Mostly setting this as a config option (in ceph.conf) would suffice. However, cephfs-mirror can connect to the remote cluster with monitor addresss and does not require remote cluster ceph config file on the primary cluster. How would we want the apply remote cluster config in this case?
cephfs-mirror can update the defaults in its cct->_conf. It woudl do this for both CephContexts it holds for each cluster, right?
Right -- that's the reason to introduce a config option to override the override :/
Updated by Venky Shankar about 3 years ago
- Status changed from Triaged to In Progress
Updated by Venky Shankar about 3 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 40885
Updated by Venky Shankar almost 3 years ago
- Related to Bug #50224: qa: test_mirroring_init_failure_with_recovery failure added
Updated by Patrick Donnelly almost 3 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot almost 3 years ago
- Copied to Backport #50871: pacific: cephfs-mirror: use sensible mount/shutdown timeouts added
Updated by Loïc Dachary almost 3 years ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".