Project

General

Profile

Actions

Fix #4635

closed

mon: many ops expose uncommitted state

Added by Sage Weil about 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Joao Eduardo Luis
Category:
Monitor
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The prepare_update() methods are tricky because they need to make changes relative to uncommitted (pending) state. If they are a noop based on that state, they need to still wait for a commit, even though they aren't making an additional change. This isn't handled correctly in many of the OSDMonitor CLI commands... osd rm, osd crush rm to name just two.

A simple pattern that might make it easy to catch this is for a r=0 value at the end of the function to wait for a commit.


Related issues 2 (0 open2 closed)

Related to Ceph - Bug #4836: crush_ops failureResolvedSamuel Just04/26/2013

Actions
Related to Ceph - Bug #6047: mon: Assert and monitor-crash when attemting to create pool-snapshots while rbd-snapshots are in use or have been used on a poolResolvedJoao Eduardo Luis08/18/2013

Actions
Actions #1

Updated by Sage Weil almost 11 years ago

  • Translation missing: en.field_story_points set to 8.00
Actions #2

Updated by Sage Weil over 10 years ago

  • Target version set to v0.68
Actions #3

Updated by Sage Weil over 10 years ago

  • Status changed from New to 12
  • Source changed from Development to Q/A

teuthology-2013-08-02_01:00:11-rados-next-testing-basic-plana/93344 for a recent occurance

Actions #4

Updated by Joao Eduardo Luis over 10 years ago

  • Assignee set to Joao Eduardo Luis
Actions #5

Updated by Joao Eduardo Luis over 10 years ago

We've fixed a couple of cases on the OSDMonitor and merged them into master. I'll keep this open for a while longer while I check for other potential cases and will close it if I find none.

Actions #6

Updated by Sage Weil over 10 years ago

  • Status changed from 12 to In Progress
Actions #7

Updated by Sage Weil over 10 years ago

  • Target version changed from v0.68 to v0.68 - continued
Actions #8

Updated by Sage Weil over 10 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF