Project

General

Profile

Actions
Copy link

Bug #43186

closed

wrongly used a string type as int value for CEPH_VOLUME_SYSTEMD_TRIES and CEPH_VOLUME_SYSTEMD_INTERVAL

Added by dongdong tao over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, mimic
Regression:
No
Severity:
1 - critical
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
32106
Crash signature (v1):
Crash signature (v2):

Description

If we explicitly set the env CEPH_VOLUME_SYSTEMD_TRIES or CEPH_VOLUME_SYSTEMD_INTERVAL.
the return value of os.environ.get() will be a string.
and we misused this as an integer.

Related issues 3 (0 open — 3 closed)

Copied to ceph-volume - Bug #43198: wrongly used a string type in several os.environ.get() callsClosed

Actions
Copied to ceph-volume - Backport #43200: mimic: wrongly used a string type as int value for CEPH_VOLUME_SYSTEMD_TRIES and CEPH_VOLUME_SYSTEMD_INTERVALResolvedActions
Copied to ceph-volume - Backport #43201: nautilus: wrongly used a string type as int value for CEPH_VOLUME_SYSTEMD_TRIES and CEPH_VOLUME_SYSTEMD_INTERVALResolvedActions
Actions
Copy link
 #2

Updated by Jan Fajerski over 4 years ago

  • Status changed from New to Pending Backport
  • Backport set to nautilus, mimic
  • Pull request ID set to 32106
Actions
Copy link
 #3

Updated by Jan Fajerski over 4 years ago

  • Target version deleted (v12.2.13)
Actions
Copy link
 #4

Updated by Jan Fajerski over 4 years ago

  • Copied to Bug #43198: wrongly used a string type in several os.environ.get() calls added
Actions
Copy link
 #5

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #43200: mimic: wrongly used a string type as int value for CEPH_VOLUME_SYSTEMD_TRIES and CEPH_VOLUME_SYSTEMD_INTERVAL added
Actions
Copy link
 #6

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #43201: nautilus: wrongly used a string type as int value for CEPH_VOLUME_SYSTEMD_TRIES and CEPH_VOLUME_SYSTEMD_INTERVAL added
Actions
Copy link
 #7

Updated by dongdong tao over 4 years ago

Hi Nanthan and Jan,

I think this is also critical for Luminous, can we also make Luminous as a target backport version ?

Thanks,
Dongdong

Actions
Copy link
 #8

Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF