Project

General

Profile

Cleanup #4164

libceph: update rados.h and related code

Added by Alex Elder about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

(This work is done, I'm just documenting it because it's really
something distinct from http://tracker.ceph.com/issues/4126)

Update most of "include/linux/ceph/rados.h" to match its user space
counterpart in "src/include/rados.h" in the ceph tree.

Almost everything that has changed is either:
- added or revised comments
- added definitions (therefore no real effect on existing code)
- defining the same value a different way (e.g., "1 << 0" vs "1")

The only exceptions are:
- The declaration of ceph_osd_state_name() was excluded; that
will be inserted in the next patch.
- ceph_osd_op_mode_read() and ceph_osd_op_mode_modify() are
defined differently, but they were never used in the kernel
- CEPH_OSD_FLAG_PEERSTAT is now CEPH_OSD_FLAG_PEERSTAT_OLD, but
that was never used in the kernel

Anything that was present in this file but not in its user space
counterpart was left intact here. I left the definitions of
EOLDSNAPC and EBLACKLISTED using numerical values here; I'm
not sure the right way to go with those.

Signed-off-by: Alex Elder <>

History

#1 Updated by Alex Elder about 11 years ago

(Another commit related to this.)

libceph: add ceph_osd_state_name()

Add the definition of ceph_osd_state_name(), to match its
counterpart in user space.

Signed-off-by: Alex Elder <>

#2 Updated by Alex Elder about 11 years ago

(Another commit related to this.)

libceph: update ceph_osd_op_name()

Update ceph_osd_op_name() to include the newly-added definitions in
"rados.h", and to match its counterpart in the user space code.

Signed-off-by: Alex Elder <>

#3 Updated by Alex Elder about 11 years ago

The following have been posted for review to resolve this:

[PATCH 0/3] libceph: update rados.h and related code (4164)
[PATCH 1/3] libceph: update rados.h
[PATCH 2/3] libceph: add ceph_osd_state_name()
[PATCH 3/3] libceph: update ceph_osd_op_name()

#4 Updated by Alex Elder about 11 years ago

  • Status changed from In Progress to Resolved

commit 0315a7770983bbe69211efed1aaee08324acd54c
Author: Alex Elder <>
Date: Fri Feb 15 11:42:30 2013 -0600

libceph: update rados.h

commit 4b568b1aaf23d0ce64b98d01d5ad1bcc7694440a
Author: Alex Elder <>
Date: Fri Feb 15 11:42:30 2013 -0600

libceph: add ceph_osd_state_name()

commit 2979ddb11befcd757a6ab5a04fad9e264560385b
Author: Alex Elder <>
Date: Fri Feb 15 11:42:30 2013 -0600

libceph: update ceph_osd_op_name()

Also available in: Atom PDF