Project

General

Profile

Actions

Bug #40863

closed

cephfs-shell: rmdir with -p attempts to delete non-dir files as well

Added by Rishabh Dave over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Going through do_rmdir in cephfs-shell, I don't see any checks that stop the method from deleting non-directory files.

Reproducing the bug -

CephFS:~/>>> ls dir2/
file1
CephFS:~/>>> rmdir -p dir2
CephFS:~/>>> ls 

Ideally, rmdir shouldn't do that since it is only suppose to delete empty directories.

Actions #1

Updated by Rishabh Dave over 4 years ago

  • Subject changed from cephfs-shell: rmdir attempts to delete non-dir as well to cephfs-shell: rmdir with -p attempts to delete non-dir files as well
Actions #2

Updated by Rishabh Dave over 4 years ago

  • Component(FS) cephfs-shell added
  • Labels (FS) task(easy) added
Actions #3

Updated by Varsha Rao over 4 years ago

  • Status changed from New to 12
  • Assignee set to Varsha Rao
  • Target version set to v15.0.0
  • Start date deleted (07/22/2019)
  • Source set to Community (dev)
Actions #4

Updated by Varsha Rao over 4 years ago

  • Source changed from Community (dev) to Development
Actions #5

Updated by Varsha Rao over 4 years ago

  • Status changed from 12 to In Progress
Actions #6

Updated by Varsha Rao over 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 31633
Actions #7

Updated by Patrick Donnelly about 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF