Project

General

Profile

Actions
Copy link

Bug #40779

closed

Unable to reset / unset module options

Added by Sebastian Wagner almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Sebastian Wagner
Category:
python interface
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
29042
Crash signature (v1):
Crash signature (v2):

Description

MgrModule.set_module_option('x', None) is supposed to reset module options. This is broken.

void PyModuleConfig::set_config() accepts a boost::optional<std::string> as value, which is `false` if the optional is unset.
But ceph_set_module_option doesn't pass None to PyModuleConfig::set_config()

Result: there is no way to unset a setting

Affects dashboard and orchestrator_cli

Related issues 1 (0 open — 1 closed)

Copied to mgr - Backport #40878: nautilus: Unable to reset / unset module optionsResolvedPrashant DActions
Actions
Copy link
 #1

Updated by Sebastian Wagner almost 5 years ago

  • Assignee set to Sebastian Wagner
Actions
Copy link
 #3

Updated by Sebastian Wagner almost 5 years ago

  • Pull request ID set to 29042
Actions
Copy link
 #4

Updated by Sebastian Wagner almost 5 years ago

  • Backport set to nautilus
Actions
Copy link
 #5

Updated by Sebastian Wagner almost 5 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #6

Updated by Sebastian Wagner almost 5 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #7

Updated by Tatjana Dehler almost 5 years ago

  • Copied to Backport #40878: nautilus: Unable to reset / unset module options added
Actions
Copy link
 #8

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF