Cleanup #4053
ceph: cleanup ceph page vector functions
0%
Description
This is just documenting some cleanup activity I've done
that I'm about to post for review.
- delete bogus (re)declarations of functions in "fs/ceph/super.h"
- have page vector functions use (void *) rather than (char *)
for their data pointers
- make sure we don't overflow a size value in rbd that's passed
to ceph_copy_from_page_vector()
- stop using the return value from ceph_copy_from_page_vector()
in rbd (in preparation for...)
- have ceph_copy_to_page_vector() and ceph_copy_from_page_vector()
not return a value (make their return type be void)
History
#1 Updated by Alex Elder about 11 years ago
- Status changed from In Progress to 4
Apparently for cleanup there is no "need review" so I'm
marking this "Feedback". I've posted a series of patches
to the ceph-devel mailing list for this.
[PATCH 0/5] ceph: cleanup ceph page vector functions
[PATCH 1/5] ceph: remove a few bogus declarations
[PATCH 2/5] libceph: use void pointers in page vector functions
[PATCH 3/5] rbd: prevent bytes transferred overflow
[PATCH 4/5] rbd: ignore result of ceph_copy_from_page_vector()
[PATCH 5/5] libceph: drop return value from page vector copy
#2 Updated by Alex Elder about 11 years ago
- Status changed from 4 to 7
Josh has reviewed these, and I've rebased them onto
the top of the testing branch. I'm going to test some
before updating testing branch to include them.
#3 Updated by Alex Elder about 11 years ago
- Status changed from 7 to Resolved
Committed to the testing branch.
9e0eb85 ceph: remove a few bogus declarations
b324814 libceph: use void pointers in page vector functions
1ceae7e rbd: prevent bytes transferred overflow
23ed6e1 rbd: ignore result of ceph_copy_from_page_vector()
903bb32 libceph: drop return value from page vector copy routines