Project

General

Profile

Actions

Fix #4034

closed

mds: fix replayed ino creation extra_bl

Added by Greg Farnum about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I haven't tested this, but I noticed during code inspection for other things that I believe all our recent fixes for create bugs — which largely rely on the MDS sending back the created ino number in extra_bl — are not resilient against replayed operations. Check out if that's the case, and fix if so.

Actions #1

Updated by Ian Colle about 11 years ago

  • Tracker changed from Bug to Fix
Actions #2

Updated by Ian Colle about 11 years ago

  • Translation missing: en.field_story_points set to 5
  • Translation missing: en.field_position set to 1
  • Translation missing: en.field_position changed from 1 to 1334
Actions #3

Updated by Ian Colle about 11 years ago

  • Translation missing: en.field_story_points deleted (5)
  • Translation missing: en.field_position deleted (1334)
  • Translation missing: en.field_position set to 1334
Actions #4

Updated by Sage Weil about 11 years ago

  • Subject changed from bugs with replayed file create operations? to mds: fix replayed ino creation extra_bl
Actions #5

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_story_points set to 2.00
Actions #6

Updated by Sage Weil about 11 years ago

  • Target version set to v0.60
Actions #7

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_story_points changed from 2.00 to 3.00
Actions #8

Updated by Ian Colle about 11 years ago

  • Translation missing: en.field_story_points changed from 3.00 to 5.00
Actions #9

Updated by Sage Weil about 11 years ago

  • Assignee set to Sage Weil
Actions #10

Updated by Sage Weil about 11 years ago

  • Status changed from New to 12
Actions #11

Updated by Sage Weil about 11 years ago

  • Status changed from 12 to Fix Under Review
Actions #12

Updated by Greg Farnum about 11 years ago

Reviewed on Github.

Actions #13

Updated by Greg Farnum about 11 years ago

There's still a bad comment in 0c0313c6f6d4e2733fcf972b49456bf1faad9255, but the rest looks good!

Actions #14

Updated by Sage Weil about 11 years ago

  • Status changed from Fix Under Review to Resolved

commit:3a7233bc8b199c97fbde9c1e44370353f0504af8

Actions

Also available in: Atom PDF