Project

General

Profile

Bug #40014

mgr/volumes: Name 'sub_name' is not defined

Added by Sebastian Wagner almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I'm getting a new mypy error in master:

pybind/mgr/volumes/module.py: note: In member "_cmd_fs_subvolumegroup_snapshot_rm" of class "Module":
pybind/mgr/volumes/module.py:552: error: Name 'sub_name' is not defined

Regression of https://github.com/ceph/ceph/pull/27594


Related issues

Copied to CephFS - Backport #40338: nautilus: mgr/volumes: Name 'sub_name' is not defined Resolved

History

#1 Updated by Ramana Raja almost 5 years ago

  • Project changed from mgr to CephFS
  • Component(FS) mgr/volumes added

#2 Updated by Ramana Raja almost 5 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 28407

#3 Updated by Venky Shankar almost 5 years ago

Ramana, I think we should just mention that this issue will be fixed w/ subvolume refactor and mark as resolved once that's merged?

It seems a bit odd (to me) mentioning this tracker in one of the commits in the refactor pr (as I do not want to have a separate commit just for this).

#4 Updated by Ramana Raja almost 5 years ago

Venky Shankar wrote:

Ramana, I think we should just mention that this issue will be fixed w/ subvolume refactor and mark as resolved once that's merged?

It seems a bit odd (to me) mentioning this tracker in one of the commits in the refactor pr (as I do not want to have a separate commit just for this).

I didn't expect that you create a separate commit, but just add 'Fixes: <tracker link>' to the commit message of the commit that fixes the issue. But if you think this is odd, I guess it's OK as long as the issue gets fixed in master and nautilus.

#5 Updated by Patrick Donnelly almost 5 years ago

  • Target version set to v15.0.0
  • Start date deleted (05/23/2019)
  • Backport set to nautilus

#6 Updated by Venky Shankar almost 5 years ago

Ramana Raja wrote:

Venky Shankar wrote:

Ramana, I think we should just mention that this issue will be fixed w/ subvolume refactor and mark as resolved once that's merged?

It seems a bit odd (to me) mentioning this tracker in one of the commits in the refactor pr (as I do not want to have a separate commit just for this).

I didn't expect that you create a separate commit, but just add 'Fixes: <tracker link>' to the commit message of the commit that fixes the issue. But if you think this is odd, I guess it's OK as long as the issue gets fixed in master and nautilus.

yeh -- don't want to just add `Fixes` the commit does much more than that...

#7 Updated by Ramana Raja almost 5 years ago

  • Status changed from Fix Under Review to Pending Backport

#8 Updated by Ramana Raja almost 5 years ago

  • Copied to Backport #40338: nautilus: mgr/volumes: Name 'sub_name' is not defined added

#9 Updated by Nathan Cutler almost 5 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF