Project

General

Profile

Actions
Copy link

Bug #39971

closed

Several embedded Grafana dashboards are not displayed due to changed uids

Added by Kiefer Chang almost 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kiefer Chang
Category:
Monitoring
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v15.0.0
ceph-qa-suite:
Pull request ID:
28169
Crash signature (v1):
Crash signature (v2):

Description

Some embedded Grafana dashboards's uids were changed recently:

PR: https://github.com/ceph/ceph/pull/28043
Tracker: http://tracker.ceph.com/issues/39652

This leads to some performance data page not displayed because mismatched uid.

Also in Cluster->OSDs page: if a user clicks an OSD, the corresponding dashboard in Performance Details always refers to osd.0.

Related issues 3 (0 open — 3 closed)

Related to Dashboard - Bug #39652: Grafana dashboards use outdated metric names from the prometheus moduleResolvedJan Fajerski

Actions
Related to Dashboard - Bug #40008: mgr/dashboard: Need a method to check references to Grafana dashboards are correct or existResolvedKiefer Chang

Actions
Copied to mgr - Backport #40006: nautilus: Several embedded Grafana dashboards are not displayed due to changed uidsResolvedJan FajerskiActions
Actions
Copy link
 #1

Updated by Kiefer Chang almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Kiefer Chang

WIP. Also thinking if it's possible to add some checks in CI for future changes.

Actions
Copy link
 #2

Updated by Kiefer Chang almost 5 years ago

  • Pull request ID set to 28169
Actions
Copy link
 #3

Updated by Nathan Cutler almost 5 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #4

Updated by Lenz Grimmer almost 5 years ago

  • Backport set to nautilus
  • Regression changed from No to Yes
Actions
Copy link
 #5

Updated by Lenz Grimmer almost 5 years ago

  • Related to Bug #39652: Grafana dashboards use outdated metric names from the prometheus module added
Actions
Copy link
 #6

Updated by Kiefer Chang almost 5 years ago

As Lenz mentioned in standup, one approach to prevent this mismatch is to add e2e tests for these pages. (This requires accompanying Prometheus and Grafana instance running)

Another approach is to create a file that maintains mappings from uids in Angular template to those in Grafana dashboards. And a script is created to check those values are identical. If a developer updates Grafana dashboard with a new uid and does not update corresponding ones in Angular templates, the script should spot this.

Actions
Copy link
 #7

Updated by Lenz Grimmer almost 5 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v15.0.0
Actions
Copy link
 #8

Updated by Nathan Cutler almost 5 years ago

  • Copied to Backport #40006: nautilus: Several embedded Grafana dashboards are not displayed due to changed uids added
Actions
Copy link
 #9

Updated by Kiefer Chang almost 5 years ago

  • Related to Bug #40008: mgr/dashboard: Need a method to check references to Grafana dashboards are correct or exist added
Actions
Copy link
 #10

Updated by Nathan Cutler almost 5 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #11

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 148 to Monitoring
Actions
Copy link

Also available in: Atom PDF