Actions
Bug #3900
closedinit-ceph should do ulimit -n's with do_root_cmd
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Chen Xiaoxi points out on ceph-devel:
Here is part of /etc/init.d/ceph script:
case "$command" in
start)
# Increase max_open_files, if the configuration calls for it.
get_conf max_open_files "8192" "max open files"
if [ $max_open_files != "0" ]; then
# Note: Don't try to do math with these numbers, because POSIX shells
# can't do 64-bit math (natively). Just treat them as strings.
cur=`ulimit -n`
if [ "x$max_open_files" != "x$cur" ]; then
Line253: ulimit -n $max_open_files
fi
fi
When using with -a option, for remote osd , this script also run ulimit on local, and results in ulimit -n didn't change in remote nodes. I think the Line 253 shoud use do_cmd instead of run directly,also line 251.
Updated by Dan Mick about 11 years ago
I think he's right, except it should be do_root_cmd, and I'm not certain if that echoes the result of the command correctly so that we can use `do_root_cmd ulimit -n` to get it.
Updated by Dan Mick about 11 years ago
- Status changed from New to Fix Under Review
Updated by Dan Mick about 11 years ago
- Status changed from Fix Under Review to Resolved
84a024b647c0ac2ee5a91bacdd4b8c966e44175c in next, cherry-pick -x'ed to bobtail
Actions