Bug #38627: insights is not Python 3 compatible - mgr - Ceph

Actions

Copy link

Bug #38627

closed

insights is not Python 3 compatible

Added by Sebastian Wagner about 5 years ago. Updated almost 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Kefu Chai

Category:

Target version:

% Done:

Source:

Community (dev)

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

27926

Crash signature (v1):

Crash signature (v2):

Description

/src/scripts/run_mypy.sh revealed some type errors in the insights module:

pybind/mgr/insights/module.py: note: In member "do_prune_health" of class "Module":
pybind/mgr/insights/module.py:298: error: Name 'errno' is not defined
pybind/mgr/insights/module.py: note: In member "testing_set_now_time_offset" of class "Module":
pybind/mgr/insights/module.py:310: error: Name 'long' is not defined
pybind/mgr/insights/module.py: note: In member "handle_command" of class "Module":
pybind/mgr/insights/module.py:320: error: Name 'cmd' is not defined

Especially "Name 'long' is not defined" looks like a Python 3 incompatibility