Bug #38626: pg_autoscaler is not Python 3 compatible - mgr - Ceph

Actions

Copy link

Bug #38626

closed

pg_autoscaler is not Python 3 compatible

Added by Sebastian Wagner about 5 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

xie xingguo

Category:

pg_autoscaler module

Target version:

% Done:

Source:

Community (dev)

Tags:

Backport:

nautilus

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

26831

Crash signature (v1):

Crash signature (v2):

Description

src/scripts/run_mypy.sh revealed some type errors:

from https://gist.github.com/sebastian-philipp/25f70aae3b0d21b1a781c110a7ef8be4

pybind/mgr/pg_autoscaler/module.py: note: In member "get_subtree_resource_status" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:192: error: "Dict[Any, Any]" has no attribute "itervalues" 
pybind/mgr/pg_autoscaler/module.py: note: In member "_maybe_adjust" of class "PgAutoscaler":
pybind/mgr/pg_autoscaler/module.py:359: error: Name 'cr_name' is not defined
pybind/mgr/pg_autoscaler/module.py:410: error: "Dict[Any, float]" has no attribute "iteritems" 
pybind/mgr/pg_autoscaler/module.py:437: error: "Dict[Any, int]" has no attribute "iteritems"

Those errors look like some incompatibilities to Python 3.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Sebastian Wagner about 5 years ago

the cr_name issue was fixed with https://github.com/ceph/ceph/pull/26831

Actions

Copy link

Updated by Sebastian Wagner about 5 years ago

Description updated (diff)

Actions

Copy link

Updated by Sebastian Wagner about 5 years ago

Backport set to nautilus

Actions

Copy link

Updated by Sage Weil about 5 years ago

Status changed from New to Pending Backport

Actions

Copy link

Updated by Nathan Cutler about 5 years ago

Copied to Backport #38982: nautilus: pg_autoscaler is not Python 3 compatible added

Actions

Copy link

Updated by Nathan Cutler about 5 years ago

Assignee set to xie xingguo
Pull request ID set to 26831

Actions

Copy link

Updated by Sebastian Wagner almost 5 years ago

The other PR is https://github.com/ceph/ceph/pull/27154

Actions

Copy link

Updated by Nathan Cutler almost 5 years ago

Sebastian Wagner wrote:

The other PR is https://github.com/ceph/ceph/pull/27154

And here's another: https://github.com/ceph/ceph/pull/27079 ( partially backported to nautilus by https://github.com/ceph/ceph/pull/27387 )

(This is in addition to https://github.com/ceph/ceph/pull/26831 which is reflected in the "Pull request ID" field of this tracker issue... - that one was merged into master before nautilus was released.)

Actions

Copy link