Bug #38591
closedPlease create "ceph-luminous" branch for https://github.com/ceph/rocksdb
0%
Description
The ceph luminous branch references the rocksdb submodule at a commit that doesn't have a name. This means you can't fetch it directly, and I think it means that the commit is subject to garbage collection.
neko-shogun:tmp geofft$ git clone https://github.com/ceph/ceph -b luminous neko-shogun:ceph geofft$ git rev-parse HEAD:src/rocksdb b181f1714a4baecaf7dff4c8417b20f5e6a41585 neko-shogun:ceph geofft$ git fetch https://github.com/ceph/rocksdb b181f1714a4baecaf7dff4c8417b20f5e6a41585 error: Server does not allow request for unadvertised object b181f1714a4baecaf7dff4c8417b20f5e6a41585 neko-shogun:ceph geofft$ git ls-remote https://github.com/ceph/rocksdb | grep b181f1714a4baecaf7dff4c8417b20f5e6a41585 neko-shogun:ceph geofft$
git submodule init works (for now at least) because it clones master and then switches to the commit. It seems that the commit is part of the same pack as master or something - that commit is independent of master.
It looks like mimic and nautilus have named branches for their submodules:
neko-shogun:ceph geofft$ git ls-remote https://github.com/ceph/rocksdb | grep ceph- 9d834c68d8cdf9ba02ee4503827f33e1da4cb761 refs/heads/ceph-mimic 37828c548a886dccf58a7a93fc2ce13877884c0c refs/heads/ceph-nautilus
Can you do the same for the luminous branch? (I think this is just "git push origin b181f1714a4baecaf7dff4c8417b20f5e6a41585:refs/heads/ceph-luminous" or something)
Updated by Greg Farnum about 5 years ago
- Category set to build
- Assignee set to Kefu Chai
Is this something we need to worry about, Kefu?
Updated by Kefu Chai about 5 years ago
- Status changed from New to Resolved
commit pushed as ceph-luminous.
@Geoffrey, thanks for filing this issue! fixed.
@Greg Farnum, Yeah, i think it's a legitimate concern.