Backport #37977
luminous: infinite loop in OpTracker::check_ops_in_flight
Release:
luminous
Crash signature (v1):
Crash signature (v2):
Description
caused by backport 02faf3dc321dfa782cac62ffa7e9f46f90feedbd (#23989)
First attempt to fix: https://github.com/ceph/ceph/pull/26048
Revert and second fix: https://github.com/ceph/ceph/pull/26088
Related issues
History
#1 Updated by Zheng Yan about 5 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 26048
#2 Updated by Patrick Donnelly about 5 years ago
- Assignee set to Zheng Yan
- Start date deleted (
01/21/2019) - Severity changed from 3 - minor to 1 - critical
- Component(FS) MDS added
#3 Updated by Patrick Donnelly about 5 years ago
- Related to Backport #23989: luminous: mds: don't report slow request for blocked filelock request added
#4 Updated by Yuri Weinstein about 5 years ago
#5 Updated by Patrick Donnelly about 5 years ago
- Status changed from Fix Under Review to Resolved
#6 Updated by Nathan Cutler about 5 years ago
- Tracker changed from Bug to Backport
- Target version changed from v10.2.11 to v12.2.11
#7 Updated by Nathan Cutler about 5 years ago
- Release set to luminous
#8 Updated by Nathan Cutler about 5 years ago
- Description updated (diff)
#9 Updated by Adam Tygart about 5 years ago
Unless I'm mistaken, that pull request doesn't look like it does anything useful.
if (!i->warn_interval_multiplier) { continue; ++i; }
continue comes before the ++i, therefore the rest of the if statement gets skipped, and the loop restarts.
shouldn't that be:
if (!i->warn_interval_multiplier) { ++i; continue; }
#10 Updated by Zheng Yan about 5 years ago
you are right, sorry
#11 Updated by Zheng Yan about 5 years ago
- Status changed from Resolved to In Progress
#12 Updated by Nathan Cutler about 5 years ago
- Description updated (diff)
#13 Updated by Nathan Cutler about 5 years ago
- Status changed from In Progress to Resolved