Project

General

Profile

Backport #37977

luminous: infinite loop in OpTracker::check_ops_in_flight

Added by Zheng Yan about 1 month ago. Updated 29 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Release:
luminous

Description

caused by backport 02faf3dc321dfa782cac62ffa7e9f46f90feedbd (#23989)

First attempt to fix: https://github.com/ceph/ceph/pull/26048

Revert and second fix: https://github.com/ceph/ceph/pull/26088


Related issues

Related to fs - Backport #23989: luminous: mds: don't report slow request for blocked filelock request Resolved

History

#1 Updated by Zheng Yan about 1 month ago

  • Status changed from New to Need Review
  • Pull request ID set to 26048

#2 Updated by Patrick Donnelly about 1 month ago

  • Assignee set to Zheng Yan
  • Start date deleted (01/21/2019)
  • Severity changed from 3 - minor to 1 - critical
  • Component(FS) MDS added

#3 Updated by Patrick Donnelly about 1 month ago

  • Related to Backport #23989: luminous: mds: don't report slow request for blocked filelock request added

#5 Updated by Patrick Donnelly about 1 month ago

  • Status changed from Need Review to Resolved

#6 Updated by Nathan Cutler about 1 month ago

  • Tracker changed from Bug to Backport
  • Target version changed from v10.2.11 to v12.2.11

#7 Updated by Nathan Cutler about 1 month ago

  • Release set to luminous

#8 Updated by Nathan Cutler about 1 month ago

  • Description updated (diff)

#9 Updated by Adam Tygart 30 days ago

Unless I'm mistaken, that pull request doesn't look like it does anything useful.

      if (!i->warn_interval_multiplier) {
    continue;
    ++i;
      }

continue comes before the ++i, therefore the rest of the if statement gets skipped, and the loop restarts.

shouldn't that be:

      if (!i->warn_interval_multiplier) {
    ++i;
    continue;
      }

#10 Updated by Zheng Yan 30 days ago

you are right, sorry

#11 Updated by Zheng Yan 30 days ago

  • Status changed from Resolved to In Progress

#12 Updated by Nathan Cutler 30 days ago

  • Description updated (diff)

#13 Updated by Nathan Cutler 29 days ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF