Project

General

Profile

Actions
Copy link

Tasks #3755

closed

krbd: use new request tracking code for sync object operations

Added by Alex Elder over 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Alex Elder
Target version:
-
% Done:

100%

Tags:
Reviewed:
Affected Versions:
Pull request ID:

Description

The last request type still using the old request tracking code
is for handling synchronous operations. There are three types
of these currently used: synchronous read (for the image header
object); synchronous watch request; and synchronous class method
calls.

Implement these using the new mechanism, then get rid of the old.

Subtasks 1 (0 open — 1 closed)

Subtask #3741: krbd: rework request tracking codeResolvedAlex Elder01/07/2013

Actions
Actions
Copy link
 #1

Updated by Ian Colle over 11 years ago

  • Parent task set to #3754
Actions
Copy link
 #2

Updated by Alex Elder over 11 years ago

  • Estimated time set to 0:00 h

I have been looking in detail at how the watch requests are
implemented and in the process identified a few potential
problems (documented in 3860, but that depends on 3859 which
depends on 3858).

In any case I've got the watch request operation mostly complete, but
now need to tidy it up a little bit and run it through a "real" test
(in teuthology rather than just UML).

Actions
Copy link
 #3

Updated by Alex Elder over 11 years ago

The sync header read operation was another one that was needed.
That's basically done too.

All of this will be reviewed at some point, but I want to report
progress as I make it.

Actions
Copy link
 #4

Updated by Alex Elder over 11 years ago

  • Status changed from New to In Progress

I have completed implementing all of these in the new request
code:
- synchronous object read (for v1 header objects)
- synchronous setup and teardown of watch requests
- synchronous class method calls

I have a little more work to do to clean up this code in
preparation for review but in the mean time am continuously
testing it.

And this work is therefore "In progress."

Actions
Copy link
 #5

Updated by Alex Elder over 11 years ago

  • Status changed from In Progress to Fix Under Review
  • Estimated time set to 0:00 h

I've posted this code for review. I continue to do testing.

Actions
Copy link
 #6

Updated by Alex Elder over 11 years ago

  • Project changed from Linux kernel client to rbd
  • Estimated time set to 0:00 h
  • Parent task deleted (#3754)
Actions
Copy link
 #7

Updated by Alex Elder about 11 years ago

  • Status changed from Fix Under Review to 7
  • Estimated time set to 0:00 h
Actions
Copy link
 #8

Updated by Alex Elder about 11 years ago

  • Status changed from 7 to Resolved
  • Estimated time set to 0:00 h

commit 304819b1a49937753ee01aa7ccf8d66547a0be36
Author: Alex Elder <>
Date: Sat Jan 19 00:30:28 2013 -0600

rbd: implement sync method with new code
Actions
Copy link
 #9

Updated by Alex Elder about 11 years ago

commit 5d08568324f53368f927cc10927b1b105533c044
Author: Alex Elder <>
Date: Thu Jan 17 12:25:27 2013 -0600

rbd: implement sync object read with new code

commit cacbb12d5fdf6bd7e3b4265bb36fab168356162c
Author: Alex Elder <>
Date: Fri Jan 18 12:31:10 2013 -0600

rbd: implement watch/unwatch with new code

commit 304819b1a49937753ee01aa7ccf8d66547a0be36
Author: Alex Elder <>
Date: Sat Jan 19 00:30:28 2013 -0600

rbd: implement sync method with new code
Actions
Copy link

Also available in: Atom PDF