Bug #37542: nvme partitions aren't mapped back to device - RADOS - Ceph

Actions

Copy link

Bug #37542

closed

nvme partitions aren't mapped back to device

Added by Sage Weil over 5 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Sage Weil

Category:

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(RADOS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

MTFDHBG800MCG-1AN1ZABYY_ZF1000GS   reesi002:nvme0n1p1 reesi002:nvme0n1p2                                                     osd.110 osd.121 osd.28 osd.50 osd.66 osd.75 osd.86

we should only see nvme0n1, not both p1 and p2.

Actions

Copy link

Updated by Sage Weil over 5 years ago

Hrm, it looks like the code in question is

int BlkDev::wholedisk(char *device, size_t max) const
{
  dev_t id;
  int r = get_devid(&id);
  if (r < 0)
    return -EINVAL;  // hrm.

  r = blkid_devno_to_wholedisk(id, device, max, nullptr);
  if (r < 0) {
    return -EINVAL;
  }
  return 0;
}

i.e., blkid is failing to give us back the nvme0n1 device

root@reesi003:~# ls -al /dev/nvme*
crw------- 1 root root 248, 0 Mar 26  2018 /dev/nvme0
brw-rw---- 1 root disk 259, 0 Mar 26  2018 /dev/nvme0n1
brw-rw---- 1 root disk 259, 1 Jul 27 13:44 /dev/nvme0n1p1
brw-rw---- 1 root disk 259, 2 Mar 26  2018 /dev/nvme0n1p2

Actions

Copy link