Project

General

Profile

Cleanup #37337

mgr/dashboard: Consistent labeling for buttons: 'Edit pool' (pool) vs. 'Update RBD' (images) vs. 'Update' (RGW) vs. 'Submit' (Cluster wide flags) ...

Added by Ernesto Puerta 26 days ago. Updated 25 days ago.

Status:
New
Priority:
Low
Category:
dashboard/general
Target version:
Start date:
11/20/2018
Due date:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Buttons for saving Update forms are labelled differently:
  • 'Edit pool' in Pool's editor
  • 'Update RBD' in Image's editor
  • Just 'Update' in RGW users & buckets
  • 'Submit' in OSD cluster-wide flags.
For creation, it kind of happens the same:
  • 'Create Pool/Create RBD' for Pools&Images.
  • Just 'Add' for RGW.
While nothing really burning, I'd try to get a shared label for these. That would also make i18n easier. My bet is just either 'Add/Update' or just 'Submit' for both Add/Edit:
  • 'Edit' is redundant and a bit confusing, since you're already 'editing' the thing.
  • Less is more: 'Update {{whatever}}' does not really add extra info, as the whole UI context tells you what you're updating. And this way you avoid naming inconsistencies like the 'Update RBD' when you are 'Editing an Image'.
  • 'Update' vs. 'Submit': Submit sounds more vintage (web 1.0, aka 'submit a form'), but 'Update' forces you to keep 'Add' and 'Update' (nothing terrible though).

Any thoughts?

History

#1 Updated by Ernesto Puerta 26 days ago

  • Subject changed from Consistent labeling for buttons: 'Edit pool' (pool) vs. 'Update RBD' (images) vs. 'Update' (RGW) vs. 'Submit' (Cluster wide flags) ... to mgr/dashboard: Consistent labeling for buttons: 'Edit pool' (pool) vs. 'Update RBD' (images) vs. 'Update' (RGW) vs. 'Submit' (Cluster wide flags) ...

#2 Updated by Ernesto Puerta 25 days ago

I briefly went through both EOS and Patternfly projects for guidelines:
  • in EOS I didn't find any direct suggestion.
  • in PF they're commonly using 'Save' and 'Cancel' (instead of our 'Edit'/'Update'/'Submit' and 'Back').

Also available in: Atom PDF