https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2018-11-02T10:26:56ZCeph Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1240022018-11-02T10:26:56ZLenz Grimmer
<ul></ul><p>Zack Cerza wrote:</p>
<blockquote>
<p>Currently the dashboard polls both <code>/api/summary</code> and <code>/api/dashboard/health</code> every 5s. The latter endpoint returns a large amount of data, but the amount needed to actually render the dashboard is quite small by comparison.</p>
</blockquote>
<p>I think these endpoints are a verbatim copy of the ones used by the original read-only dashboard. They likely haven't been modified when dashboard v2 was initially created.</p>
<blockquote>
<p>I think it would make sense to get rid of <code>/api/dashboard/health</code> and replace it with e.g. <code>/api/health/full</code> and <code>/api/health/minimal</code>.</p>
</blockquote>
<p>And the content of <code>/api/health/minimal</code> would be defined by the requirements of the dashboard landing page?</p>
<blockquote>
<p>Another idea would be to merge the minimal health data into <code>/api/summary</code>, but that might warrant more discussion.</p>
<p>A caveat here is that <code>/api/dashboard/health</code> currently provides logging data which will be moving out as a result of <a class="issue tracker-2 status-3 priority-3 priority-lowest closed" title="Feature: mgr/dashboard: Move Cluster/Audit logs from front page to dedicated "Logs" page (Resolved)" href="https://tracker.ceph.com/issues/24571">#24571</a> - perhaps the solution to that piece is to simply move that data out to a new <code>/api/logs</code> endpoint.</p>
</blockquote>
<p>Sounds like a good idea to me. The current <code>/api/dashboard/health</code> endpoint seems to be a tad bit too bloated...</p> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1240142018-11-02T16:15:29ZZack Cerza
<ul></ul><p>An update on what my WIP has changed so far, along with some thoughts:</p>
<ol>
<li><code>/api/health/full</code> provides what <code>/api/dashboard/health</code> used to report, minus logs.
<ul>
<li>This isn't used by anything, yet.</li>
</ul>
</li>
<li><code>/api/health/minimal</code> provides just what the dashboard landing page needs, and no more.
<ul>
<li>Since I am preserving the original format to avoid unnecessary compatibility breaks, certain fields look a bit awkward. For example, the only thing we need to know about pools is the count - so that piece looks like <code>"pools": [{}, {}, {}]</code></li>
</ul>
</li>
<li><code>/api/logs/all</code> provides audit_log and clog.
<ul>
<li>I'm not sure if we would ever want one log and not the other. If so, I'll add separate endpoints. If not, we might prefer to just use <code>/api/logs</code> for both, dropping the <code>/all</code>.</li>
</ul>
</li>
<li><code>/api/dashboard</code> is gone.</li>
</ol>
<p>Of course I'm open to any feedback on these items. I'm very close to submitting a PR, and am happy to make further changes.</p> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1240152018-11-02T16:15:37ZZack Cerza
<ul><li><strong>% Done</strong> changed from <i>50</i> to <i>80</i></li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1240302018-11-02T21:59:44ZZack Cerza
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Fix Under Review</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>100</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/24900">https://github.com/ceph/ceph/pull/24900</a></p> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1243422018-11-08T16:58:00ZLenz Grimmer
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Feature</i></li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1243742018-11-09T09:28:56ZLenz Grimmer
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-8 priority-4 priority-default closed" href="/issues/34320">Bug #34320</a>: mgr/dashboard: Read/Write OPS in pool stats always show 0</i> added</li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1243762018-11-09T09:29:53ZLenz Grimmer
<ul></ul><p>Just wondering: is the issue mentioned in <a class="issue tracker-1 status-8 priority-4 priority-default closed" title="Bug: mgr/dashboard: Read/Write OPS in pool stats always show 0 (Won't Fix)" href="https://tracker.ceph.com/issues/34320">#34320</a> somehow related to this work? Or have these pool metrics been obtained via a different API endpoint?</p> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1244052018-11-09T23:09:43ZZack Cerza
<ul></ul><p>Lenz Grimmer wrote:</p>
<blockquote>
<p>Just wondering: is the issue mentioned in <a class="issue tracker-1 status-8 priority-4 priority-default closed" title="Bug: mgr/dashboard: Read/Write OPS in pool stats always show 0 (Won't Fix)" href="https://tracker.ceph.com/issues/34320">#34320</a> somehow related to this work? Or have these pool metrics been obtained via a different API endpoint?</p>
</blockquote>
<p>I hadn't seen that issue - I don't think they're related at all.</p> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1244462018-11-10T12:21:50ZLenz Grimmer
<ul><li><strong>Pull request ID</strong> set to <i>24900</i></li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1249972018-11-22T10:04:52ZLenz Grimmer
<ul><li><strong>Target version</strong> set to <i>v14.0.0</i></li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1252992018-11-28T09:57:47ZLenz Grimmer
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul> Dashboard - Feature #36675: mgr/dashboard: Provide API endpoint providing minimal health datahttps://tracker.ceph.com/issues/36675?journal_id=1344162019-04-12T11:47:03ZErnesto Puerta
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>