Bug #36572: ceph-in: --connect-timeout doesn't work while pinging mon - RADOS - Ceph

Actions

Copy link

Bug #36572

closed

ceph-in: --connect-timeout doesn't work while pinging mon

Added by Rishabh Dave over 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Rishabh Dave

Category:

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(RADOS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Saw the following output while working on PR 21432 -

$ date; ./bin/ceph ping mon.b --connect-timeout=5; date
Tue Oct 23 13:53:02 UTC 2018
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2018-10-23 13:53:02.153 7ff84085e700 -1 WARNING: all dangerous and experimental features are enabled.
^C(-4, None, 'Interrupted!')
Tue Oct 23 13:53:27 UTC 2018

The command ideally should have terminated by itself at 6th second after the command was issued. But, right now, that doesn't happen. I am not sure, but as far as I can see this is different from issue 19348.

The fix is to pass the timeout to the underlying function calls to run_in_thread() here and here which already accepts timeouts as an argument.