Project

General

Profile

Cleanup #36356

mgr/dashboard: Check if Grafana dashboards exist

Added by Ricardo Marques 2 months ago. Updated 18 days ago.

Status:
Need Review
Priority:
Low
Category:
dashboard/monitoring
Target version:
Start date:
10/09/2018
Due date:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

If grafana is configured by running `ceph dashboard set-grafana-api-url <grafana-server-url>`, but a required dashboard is not available, user will see the following page.

It would be useful if Ceph Dashboard checks if the required dashboard exists beforehand, and display a more useful message including the name of the missing dashboard.

Screenshot_from_2018-10-09_11-41-22.png View (95.5 KB) Ricardo Marques, 10/09/2018 12:16 PM

History

#1 Updated by Ricardo Marques 2 months ago

  • Priority changed from Normal to Low

#2 Updated by Kanika Murarka about 1 month ago

This bug seems to require proxy, as Grafana doesnt allow to enable CORS explicitly1.

[1] https://community.grafana.com/t/how-to-allow-access-control-allow-origin-for-all-the-apis/2045

#3 Updated by Ricardo Marques about 1 month ago

@Kanika Murarka I was expecting that doing an HTTP get to the grafana dashboard URL before displaying that URL in the iframe would be enough to know if that dashboard is available.

This validation must be done by the backend, in a dedicated endpoint that checks if a certain dashboard is available.

#4 Updated by Kanika Murarka about 1 month ago

Yes, it can be done through the backend. Thanks

#5 Updated by Kanika Murarka 19 days ago

  • Status changed from New to Need Review

#6 Updated by Lenz Grimmer 18 days ago

  • Subject changed from Check if grafana dashboard exists to mgr/dashboard: Check if Grafana dashboards exist
  • Target version set to v14.0.0
  • Pull request ID set to 25154

Also available in: Atom PDF