Backport #36155
mimic: [rbd-mirror] interrupted image sync can result in orphaned snapshots
Status:
Rejected
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
Release:
mimic
Crash signature (v1):
Crash signature (v2):
Related issues
History
#1 Updated by Nathan Cutler over 5 years ago
- Copied from Bug #24140: [rbd-mirror] interrupted image sync can result in orphaned snapshots added
#2 Updated by Nathan Cutler over 5 years ago
- Status changed from New to Need More Info
- Assignee set to Jason Dillaman
non-trivial backport because it seems to depend on b498aa0380b which is itself non-trivial
#3 Updated by Jason Dillaman over 5 years ago
- Status changed from Need More Info to In Progress
@Nathan: I'll start the process once the two pending mimic RBD PRs are merged (just to avoid a moving target)
#4 Updated by Nathan Cutler almost 4 years ago
@Jason - I tried the cherry-pick and there are conflicts I don't feel comfortable resolving:
You are currently cherry-picking commit f1eb1c1992b. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: src/test/rbd_mirror/image_replayer/test_mock_BootstrapRequest.cc modified: src/test/rbd_mirror/test_mock_ImageReplayer.cc modified: src/tools/rbd_mirror/CMakeLists.txt modified: src/tools/rbd_mirror/image_replayer/BootstrapRequest.cc modified: src/tools/rbd_mirror/image_replayer/BootstrapRequest.h modified: src/tools/rbd_mirror/image_replayer/CreateImageRequest.h modified: src/tools/rbd_mirror/image_replayer/PrepareRemoteImageRequest.h new file: src/tools/rbd_mirror/image_replayer/Utils.cc new file: src/tools/rbd_mirror/image_replayer/Utils.h Unmerged paths: (use "git add <file>..." to mark resolution) both modified: src/test/rbd_mirror/image_replayer/test_mock_CreateImageRequest.cc both modified: src/tools/rbd_mirror/ImageReplayer.cc both modified: src/tools/rbd_mirror/image_replayer/CreateImageRequest.cc both modified: src/tools/rbd_mirror/image_replayer/PrepareRemoteImageRequest.cc
Is this fix needed for mimic? We've gotten this far without including it... maybe it's not a big deal if we just close this one as "Rejected", too?
#5 Updated by Jason Dillaman almost 4 years ago
- Status changed from In Progress to Rejected
Mimic is near EOL and has a low adoption rate -- rejecting for now.