Project

General

Profile

Bug #36082

ceph-pr-commits checkerd (Signed-off-by) fails with many-commits PRs

Added by Ernesto Puerta over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

PRs with many commits (or few commits with exceptionally verbose messages), like this one, do not pass the Signed-off-by check. This is due to the way the output of git log is read in Python (by means of subprocess.PIPE, which has a 64k buffer). In the sample PR, the output is 129kB, hence it blocks and times out.

+ timeout 600 /tmp/venv.PPeKSx81We/bin/py.test -vs --junitxml=/home/jenkins-build/build/workspace/ceph-pr-commits/report.xml /home/jenkins-build/build/workspace/ceph-pr-commits/ceph-build/ceph-pr-commits/build/test_commits.py
============================= test session starts ==============================
platform linux2 -- Python 2.7.5, pytest-3.8.0, py-1.6.0, pluggy-0.7.1 -- /tmp/venv.PPeKSx81We/bin/python
cachedir: .pytest_cache
rootdir: /home/jenkins-build/build/workspace/ceph-pr-commits, inifile:
collecting ... collected 1 item

ceph-build/ceph-pr-commits/build/test_commits.py::TestSignedOffByCommits::test_signed_off_by Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: Test reports were found but none of them are new. Did leafNodes run?

History

#1 Updated by Ernesto Puerta over 5 years ago

  • Status changed from New to Triaged

#2 Updated by Ernesto Puerta over 5 years ago

  • Status changed from Triaged to In Progress

#3 Updated by Ernesto Puerta over 5 years ago

  • Status changed from In Progress to Closed

Also available in: Atom PDF