Project

General

Profile

Actions

Bug #3579

closed

kclient: Use less secure random number generator so we don't consume entropy

Added by David Zafman over 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The routines __choose_mds() and ceph_mdsmap_get_random_mds() call the kernel get_random_bytes() which gets random number suitable for key generation. Pseudo random numbers are sufficient for our purposes. Also, both cases could check if there is only 1 possible choice and skip the call to get a random number.

VMs especially can have trouble getting entropy so it is best not to consume that resource.

Actions #1

Updated by Greg Farnum over 11 years ago

  • Project changed from CephFS to Linux kernel client
  • Category deleted (46)
Actions #2

Updated by Sage Weil about 11 years ago

  • Project changed from Linux kernel client to CephFS
  • Subject changed from Use less secure random number generator so we don't consume entropy to kclient: Use less secure random number generator so we don't consume entropy
Actions #3

Updated by Sage Weil about 11 years ago

  • Priority changed from Normal to High
Actions #4

Updated by Sam Lang about 11 years ago

  • Status changed from New to In Progress
  • Assignee set to Sam Lang
Actions #5

Updated by Sam Lang about 11 years ago

  • Status changed from In Progress to Fix Under Review

Patches sent to the mailing list and pushed to wip-3579.

Actions #6

Updated by Sam Lang about 11 years ago

  • Status changed from Fix Under Review to Resolved
Actions #7

Updated by Ian Colle about 11 years ago

commit 442318d09506d33e811d9d6a7bd2514287df729d

Actions

Also available in: Atom PDF