Project

General

Profile

Actions

Cleanup #35693

closed

Cleanup #35688: mgr/dashboard: Community branding & styling recommendations

Proposed About modal box

Added by Ernesto Puerta over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
General
Target version:
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Current

Proposal

  • Change background color to brand gray (#374249)
  • Add background image (attached below), anchored to bottom/right
  • Ceph icon with full logo on top (attached below)
  • Ceph version laid out differently from downstream since upstream versioning is more verbose
  • A small drop-shadow (#374249), the same color as the background, is applied to all of the text for better readability when the text overlays the background image. Since it is the same color as the background, the drop-shadow is invisible unless the text overlaps the image.

Proposed About Modal


Files

ceph_about_fix.png (191 KB) ceph_about_fix.png Proposed About Modal Ju Lim, 09/05/2018 03:17 PM
modal_original.jpg (17.2 KB) modal_original.jpg Ernesto Puerta, 09/05/2018 03:21 PM
ceph_login_bgimage_fix.png (145 KB) ceph_login_bgimage_fix.png Background Image (source: https://unsplash.com/photos/Lu9z9qS8I_Q, free for commercial use) Ernesto Puerta, 09/05/2018 04:44 PM
Ceph_Logo_Standard_RGB_Reversed_120411_fa.png (27.5 KB) Ceph_Logo_Standard_RGB_Reversed_120411_fa.png https://ceph.com/logos/ Ernesto Puerta, 09/05/2018 05:13 PM

Related issues 2 (0 open2 closed)

Copied from Dashboard - Cleanup #35692: Proposed background colorWon't FixNeha .

Actions
Copied to mgr - Backport #45787: octopus: Proposed About modal boxResolvedLaura PaduanoActions
Actions #1

Updated by Ernesto Puerta over 5 years ago

  • File modal.jpg added
  • Copied from Cleanup #35692: Proposed background color added
Actions #2

Updated by Ernesto Puerta over 5 years ago

  • File deleted (gray_background.png)
Actions #3

Updated by Ernesto Puerta over 5 years ago

  • File modal_original.jpg added
  • Description updated (diff)
Actions #5

Updated by Ju Lim over 5 years ago

  • File deleted (modal_original.jpg)
Actions #6

Updated by Ju Lim over 5 years ago

  • File deleted (modal.jpg)
Actions #7

Updated by Ernesto Puerta over 5 years ago

  • File ceph_about_fix.png added
  • Description updated (diff)
Actions #9

Updated by Ernesto Puerta over 5 years ago

  • File deleted (ceph_about_fix.png)
Actions #11

Updated by Anonymous over 5 years ago

What is the version reported here ? I think that the version of the dashboard.
Using the "ceph version" label here could be confusing regarding the ceph versions running on the nodes themselves (osd/mon/etc..).

Maybe replacing "ceph version" by "Version" and aligned with the other items would be more consistent and less confusing.

Actions #12

Updated by Kai Wagner over 5 years ago

Combined with the Login page Option 2 this lgtm as well.

Actions #13

Updated by Lenz Grimmer over 5 years ago

  • Tags changed from UI to UI, low-hanging-fruit
Actions #14

Updated by Kanika Murarka over 5 years ago

  • Status changed from New to Fix Under Review
Actions #15

Updated by Lenz Grimmer over 5 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v14.0.0
Actions #16

Updated by Ngwa Sedrick Meh about 4 years ago

Ernesto Puerta wrote:

Current

Proposal

  • Change background color to brand gray (#374249)
  • Add background image (attached below), anchored to bottom/right
  • Ceph icon with full logo on top (attached below)
  • Ceph version laid out differently from downstream since upstream versioning is more verbose
  • A small drop-shadow (#374249), the same color as the background, is applied to all of the text for better readability when the text overlays the background image. Since it is the same color as the background, the drop-shadow is invisible unless the text overlaps the image.

Proposed About Modal

Hi I have worked on this please review the PR here https://github.com/ceph/ceph/pull/34298

Actions #17

Updated by Lenz Grimmer about 4 years ago

  • Translation missing: en.field_tag_list set to low-hanging-fruit
  • Status changed from Resolved to Fix Under Review
  • Target version deleted (v14.0.0)
  • Tags deleted (UI, low-hanging-fruit)
  • Pull request ID set to 34298
Actions #18

Updated by Lenz Grimmer about 4 years ago

  • Assignee set to Ngwa Sedrick Meh
Actions #19

Updated by Ngwa Sedrick Meh about 4 years ago

  • Pull request ID changed from 34298 to 34336

Update pull request ID

Actions #20

Updated by Ernesto Puerta about 4 years ago

  • Pull request ID changed from 34336 to 34298
Actions #21

Updated by Ernesto Puerta about 4 years ago

  • Pull request ID changed from 34298 to 34336
Actions #22

Updated by Lenz Grimmer about 4 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v16.0.0
Actions #23

Updated by Laura Paduano almost 4 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to octopus
Actions #24

Updated by Laura Paduano almost 4 years ago

Actions #25

Updated by Laura Paduano almost 4 years ago

  • Related to deleted (Backport #45738: mgr/dashboard Proposed About modal box)
Actions #26

Updated by Laura Paduano almost 4 years ago

  • Tracker changed from Cleanup to Bug
  • Regression set to No
  • Severity set to 3 - minor
Actions #27

Updated by Laura Paduano almost 4 years ago

  • Tracker changed from Bug to Cleanup
Actions #28

Updated by Nathan Cutler almost 4 years ago

Actions #29

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF