Project

General

Profile

Actions

Feature #3302

closed

ceph-disk: activate-journal, and matching udev rule

Added by Anonymous over 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Actions #1

Updated by Anonymous over 11 years ago

Summary: try starting the OSD again when the journal disk appears.

Currently, osd data disk add is seen in /etc/init/ceph-hotplug.conf, and then the $osd_data_dir/journal symlink is followed to find an external journal. If an external journal is not available at the time the OSD would start up, it'll fail.

Add a second upstart job definition, /etc/init/ceph-hotplug-journal.conf, that triggers on block device addition with ID_PART_ENTRY_TYPE=...ceff106, that peeks inside the journal to see the osd uuid associated, looks for a partition with that unique uuid (and type uuid=...ceff05d"), and then does "initctl emit block-device-added ..." to get /etc/init/ceph-hotplug.conf running for it.

Beware: there might be a race condition:

- ceph-hotplug: starts
- ceph-hotplug: no journal disk yet, cannot start osd, about to exit soon
- ceph-hotplug-journal: starts
- ceph-hotplug-journal: make sure ceph-hotplug is started (it is!)
- ceph-hotplug: finally stops (no osd running yet)
- ceph-hotplug-journal: stops (still no osd!)

To avoid that, ceph-hotplug-journal might need to see if ceph-hotplug is running, wait for the current instance to exit, and then start a new one?

Actions #2

Updated by Sage Weil about 11 years ago

  • Subject changed from upstart: provide ceph-hotplug-journal that can also trigger ceph-hotplug to ceph-disk: activate-journal, and matching udev rule
  • Status changed from New to 12
  • Priority changed from Normal to High
Actions #3

Updated by Neil Levine about 11 years ago

  • Assignee set to Anonymous
Actions #4

Updated by Sage Weil almost 11 years ago

  • Status changed from 12 to Fix Under Review
  • Assignee changed from Anonymous to Sage Weil
  • Priority changed from High to Urgent

this was causing unreliable ubuntu activation, at least in my case

Actions #5

Updated by Sage Weil almost 11 years ago

commit:a2a78e8d16db0a71b13fc15457abc5fe0091c84c

Actions #6

Updated by Sage Weil almost 11 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF