Project

General

Profile

Feature #24822

mgr/dashboard: Display logged in user

Added by Lenz Grimmer 5 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
dashboard/general
Target version:
Start date:
07/09/2018
Due date:
% Done:

0%

Source:
Tags:
dashboard, usability, low-hanging-fruit
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

PR#22758 has been merged and it's now possible to log in with multiple user accounts.

Currently, there is no visible indication of the logged in username. It should be possible to determine which user is currently logged in on the WebUI.

user-name.png View (1.45 KB) Dan Guo, 09/17/2018 09:26 AM

display-login-username.png View (3.7 KB) Dan Guo, 09/18/2018 07:19 AM

History

#1 Updated by Lenz Grimmer 3 months ago

  • Tags changed from dashboard to dashboard, usability, low-hanging-fruit

#2 Updated by Dan Guo 3 months ago

In terms of the master branch of Ceph Git Repo has the new feature "user management" under the Setting drop-down menu on the top-right, we can found the login user name in the table of "users". But I found that if a user don't have all permissions of ceph, he/she would not see the "Setting" icon, and then he/she has not the enter to see the login user name. So, I want to do this job: add an icon on the top-right navigation list, and it is a popover, just show the current login user.

#3 Updated by Ricardo Marques 3 months ago

dan Guo wrote:

In terms of the master branch of Ceph Git Repo has the new feature "user management" under the Setting drop-down menu on the top-right, we can found the login user name in the table of "users". But I found that if a user don't have all permissions of ceph, he/she would not see the "Setting" icon, and then he/she has not the enter to see the login user name. So, I want to do this job: add an icon on the top-right navigation list, and it is a popover, just show the current login user.

IMO, we should also move the existing logout action to that popover (like in Github)

#4 Updated by Dan Guo 3 months ago

Ricardo Marques wrote:

dan Guo wrote:

In terms of the master branch of Ceph Git Repo has the new feature "user management" under the Setting drop-down menu on the top-right, we can found the login user name in the table of "users". But I found that if a user don't have all permissions of ceph, he/she would not see the "Setting" icon, and then he/she has not the enter to see the login user name. So, I want to do this job: add an icon on the top-right navigation list, and it is a popover, just show the current login user.

IMO, we should also move the existing logout action to that popover (like in Github)

Yes, I think your idea is good, so I will implement a simple version about this popover and present a screenshot in the attachment.

#5 Updated by Lenz Grimmer 3 months ago

dan Guo wrote:

Yes, I think your idea is good, so I will implement a simple version about this popover and present a screenshot in the attachment.

Sounds good - we're looking forward to your contribution! Thank you in advance. Let us know if you need any assistance - you can find us on the #ceph-dashboard IRC channel on OFTC.

#6 Updated by Dan Guo 3 months ago

Lenz Grimmer wrote:

Sounds good - we're looking forward to your contribution! Thank you in advance. Let us know if you need any assistance - you can find us on the #ceph-dashboard IRC channel on OFTC.

Hi, I already completed a simple version about this, while I use the drop-down menu instead of popover. Please see the attached.

#7 Updated by Lenz Grimmer 3 months ago

  • Description updated (diff)

#8 Updated by Volker Theile 3 months ago

If we introduce a new icon to the drop-down menu at the upper right corner then this menu should also provide some more useful entries like e.g. 'Settings' which directs the user to the user management 'Edit User' page.

#9 Updated by Dan Guo 3 months ago

dan Guo wrote:

Hi, I already completed a simple version about this, while I use the drop-down menu instead of popover. Please see the attached.

After the last implementation of 'show login username', I improved the style of the drop-down menu and gave a screenshot in the attachment. For this drop-down, we can add the "Settings" menu in it, just like in github.

#10 Updated by Lenz Grimmer 3 months ago

dan Guo wrote:

After the last implementation of 'show login username', I improved the style of the drop-down menu and gave a screenshot in the attachment. For this drop-down, we can add the "Settings" menu in it, just like in github.

This looks great, thank you! Would you mind submitting a pull request for this?

#11 Updated by Dan Guo 3 months ago

Lenz Grimmer wrote:

This looks great, thank you! Would you mind submitting a pull request for this?

Of course I don't, I will create a new merge request on the master branch of ceph github repo.

#12 Updated by Dan Guo 3 months ago

#13 Updated by Dan Guo 3 months ago

dan Guo wrote:
PR#24166

Seems this pull request failed at Make Check in jenkins

#14 Updated by Lenz Grimmer 3 months ago

dan Guo wrote:

dan Guo wrote:
PR#24166

Seems this pull request failed at Make Check in jenkins

Note that you don't have to close a pull request if you observe such a failure. Simply amend your commit and "push -f" it into your repo again. GitHub will update the pull request accordingly. But please consider using a dedicated branch, not "master".

#15 Updated by Ricardo Marques 3 months ago

  • Status changed from New to Need Review

#18 Updated by Ricardo Marques 2 months ago

  • Status changed from Need Review to Resolved

#19 Updated by Lenz Grimmer about 2 months ago

  • Assignee set to Dan Guo

Also available in: Atom PDF