Project

General

Profile

Cleanup #24820

overhead of g_conf->get_val<type>("config name") is high

Added by Zheng Yan 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Performance/Resource Usage
Target version:
Start date:
07/08/2018
Due date:
% Done:

0%

Tags:
Backport:
mimic,luminous
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:

Screen Shot 2018-07-08 at 16.13.15.png View (180 KB) Zheng Yan, 07/08/2018 08:14 AM


Related issues

Copied to fs - Backport #25043: luminous: overhead of g_conf->get_val<type>("config name") is high Resolved
Copied to fs - Backport #25044: mimic: overhead of g_conf->get_val<type>("config name") is high Resolved

History

#1 Updated by Zheng Yan 5 months ago

!http://tracker.ceph.com/attachments/download/3540/Screen%20Shot%202018-07-08%20at%2016.13.15.pngļ¼

#2 Updated by Patrick Donnelly 5 months ago

Idea for fix is to use cache variable where hot paths use get_val. Example:

https://github.com/ceph/ceph/blob/975528f632f73fbffa3f1fee304e3bbe3296cffc/src/mds/Migrator.cc#L3441-L3449

#3 Updated by Patrick Donnelly 5 months ago

  • Category set to Performance/Resource Usage
  • Status changed from New to Need Review
  • Assignee set to Zheng Yan
  • Priority changed from Normal to High
  • Target version set to v14.0.0
  • Backport set to mimic,luminous
  • Component(FS) MDS added

#5 Updated by Patrick Donnelly 5 months ago

  • Status changed from Need Review to Pending Backport

#6 Updated by Patrick Donnelly 5 months ago

  • Copied to Backport #25043: luminous: overhead of g_conf->get_val<type>("config name") is high added

#7 Updated by Patrick Donnelly 5 months ago

  • Copied to Backport #25044: mimic: overhead of g_conf->get_val<type>("config name") is high added

#9 Updated by Nathan Cutler 3 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF