Project

General

Profile

Actions
Copy link

Cleanup #24820

closed

overhead of g_conf->get_val<type>("config name") is high

Added by Zheng Yan almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Zheng Yan
Category:
Performance/Resource Usage
Target version:
Ceph - v14.0.0
% Done:

0%

Tags:
Backport:
mimic,luminous
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:

Files

Screen Shot 2018-07-08 at 16.13.15.png (180 KB) Screen Shot 2018-07-08 at 16.13.15.png Zheng Yan, 07/08/2018 08:14 AM

Related issues 2 (0 open — 2 closed)

Copied to CephFS - Backport #25043: luminous: overhead of g_conf->get_val<type>("config name") is highResolvedZheng YanActions
Copied to CephFS - Backport #25044: mimic: overhead of g_conf->get_val<type>("config name") is highResolvedZheng YanActions
Actions
Copy link
 #1

Updated by Zheng Yan almost 6 years ago

!http://tracker.ceph.com/attachments/download/3540/Screen%20Shot%202018-07-08%20at%2016.13.15.pngļ¼

Actions
Copy link
 #2

Updated by Patrick Donnelly almost 6 years ago

Idea for fix is to use cache variable where hot paths use get_val. Example:

https://github.com/ceph/ceph/blob/975528f632f73fbffa3f1fee304e3bbe3296cffc/src/mds/Migrator.cc#L3441-L3449

Actions
Copy link
 #3

Updated by Patrick Donnelly almost 6 years ago

  • Category set to Performance/Resource Usage
  • Status changed from New to Fix Under Review
  • Assignee set to Zheng Yan
  • Priority changed from Normal to High
  • Target version set to v14.0.0
  • Backport set to mimic,luminous
  • Component(FS) MDS added
Actions
Copy link
 #5

Updated by Patrick Donnelly almost 6 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #6

Updated by Patrick Donnelly almost 6 years ago

  • Copied to Backport #25043: luminous: overhead of g_conf->get_val<type>("config name") is high added
Actions
Copy link
 #7

Updated by Patrick Donnelly almost 6 years ago

  • Copied to Backport #25044: mimic: overhead of g_conf->get_val<type>("config name") is high added
Actions
Copy link
 #9

Updated by Nathan Cutler over 5 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF